Closed Bug 279171 Opened 20 years ago Closed 18 years ago

chromehidden attribute should be set earlier

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 345560
Milestone:
Future

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: perf) 

This is a followup to bug 255372.  See especially bug 255372 comment 95.

Right now we set the chromehidden attribute way too late, after we've
constructed frames and loaded images for all the chrome that's going to be
hidden.  This has two problems:
 1. We do a lot of extra work
 2. As long as onload is fired synchronously, we're breaking a bunch of
invariants by modifying the document in the middle of code that depends on the
document not being modified.  This can cause crashes like bug 255372.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta3
Severity: normal → major
Keywords: arch, perf
Target Milestone: mozilla1.8beta3 → Future

*** This bug has been marked as a duplicate of 345560 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.