279177 - Reflow not happening for Plugin Replacement Contents

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Frank Wein [:mcsmurf]]

I tested around with the code in Gecko for the PFS (Plugin Finder Service) that
renders the replacement text and puts a logo in it (in nsObjectFrame.cpp). With
Mozilla this is only happening on some sites (all had a flash plugin on the
page). If it isn't rendered, you have to trigger a mousedown event where the
replacement content should be, then it would appear. In console "WARNING:
Couldn't add reflow command, so splitting." appeared a few times (with and
without rendering the rep. content).
If you remove the line "aPresContext->PresShell()->CancelReflowCommand(child,
&reflowType);" (1092), the replacement content appears immediately (also now it
doesn't anymore, but a few minutes ago this hack worked).

Comment 1

[Frank Wein [:mcsmurf]]

BTW: Now a mousedown event on the replacement content doesn't help anymore, now
you have to open a new tab and then switch back to the old tab to trigger a reflow.
I also couldn't get the aPresContext->PresShell()->CancelReflowCommand(child,
&reflowType); hack working anymore.

Comment 2

[[e-mail]]

Actually to demonstrate this bug all you need do is disable the default plugin.

Comment 3

[Mats Palmgren (inactive)]

We're in the process of removing support for plugins (bug 1677160) and bug 1687239 has removed the relevant Layout code, so this bug is irrelevant now.