27921 - SetWindowTile doesn't work in Composer

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Charles Manske]

We set the window title to include the document's title/url by:
nsCOMPtr<nsIBaseWindow> 
contentAreaAsWin(do_QueryInterface(mContentAreaWebShell));
res = contentAreaAsWin->SetTitle(windowCaption.GetUnicode());
but it is failing here because it doesn't think it is the owner:

nsContentTreeOwner::SetTitle(nsContentTreeOwner * const 0x0c01aa84, const 
unsigned short * 0x0012f2f8) line 394
nsDocShell::SetTitle(nsDocShell * const 0x0c01e240, const unsigned short * 
0x0012f2f8) line 1291
nsWebShell::SetTitle(nsWebShell * const 0x0c01e240, const unsigned short * 
0x0012f2f8) line 3810
nsEditorShell::UpdateWindowTitle(nsEditorShell * const 0x0c0f9360) line 1661 + 
48 bytes
nsEditorShell::PrepareDocumentForEditing(nsEditorShell * const 0x0c0f9360, 
nsIURI * 0x0c10d790) line 414
nsEditorShell::OnEndDocumentLoad(nsEditorShell * const 0x0c0f9368, 
nsIDocumentLoader * 0x0c018710, nsIChannel * 0x0c10d460, unsigned int 0) line 
3882 + 28 bytes
nsWebShell::OnEndDocumentLoad(nsWebShell * const 0x0c01e2f0, nsIDocumentLoader * 
0x0c018710, nsIChannel * 0x0c10d460, unsigned int 0) line 2935

Comment 1

[Charles Manske]

Travis explained the problem. We needed to add:
  contenttitlesettting="true"
window attribute to allow the editor content webshell to set title
on the app.

Comment 2

[Charles Manske]

Checked in 2/15

Comment 3

[sujay]

I do not see the URL in the title....just "untitled - Composer"

Comment 4

[Charles Manske]

There is no URL if the page is new, so there's nothing
to put there. You will see the url in [ ] after the title if you open an 
existing file.
Oh, did you use "untitled" as a filename?
I do see a bug: after if you save the page, it should should take that file URL
and update the title to include that URL. We are calling SetDocumentTitle
before prompting to save the file, so it doesn't know the file URL yet!
I'll file a separate bug for that.

Comment 5

[sujay]

yes I opened an existing doc from C:\temp\22223.html

and it did not display this in the window title...

I expected to see something liek this: file:///C:\temp\22223.html

something like that...don't quote me...you get the idea...

Comment 6

[sujay]

we may have to reopen this one...try opening an existing file....it doesn't load
the full URL path..just the filename

Comment 7

[sujay]

verified in 2/17 build.

Comment 8

[Charles Manske]

Oops! I forgot that we don't want to show the full URL, since that's too big.
We just show the "file.ext" part, so your verification is correct.