279210 - Compiler warning because of nsCOMPtr<nsIPresContext>

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Aaron Leventhal]

I'm getting multiple repetitions of the following VC++ compiler warnings when
building the accessible directory:

nsHTMLInputElement.cpp
../../../../dist\include\xpcom\nsCOMPtr.h(228) : warning C4624:
'nsDerivedSafe<T>' : destructor could not be generated because a base class
destructor is inaccessible
        with
        [
            T=nsPresContext
        ]
        c:/moz\mozilla\content\html\content\src\nsHTMLInputElement.cpp(705) :
see reference to class template instantiation 'nsDerivedSafe<T>' being compiled
        with
        [
            T=nsPresContext
        ]

Comment 1

[Aaron Leventhal]

Actually, I'm noticing this in more places than just the accessible directory.

I believe that getting rid of the nsCOMPtr<> around nsIPresContext fixes the
problem.

Comment 2

[Régis Caspar]

Attachment: define a non implemented dtor for nsDeriveSafe

I saw this kind of warning when compiling nsProxyEventClass, nsObserverEnumerator, nsCategoryManager, xptiAdditionalManagersEnumerator, nsProxyEventObject, nsEventQueueServiceImpl, nsXPCFastLoadIO, nsPACMan, nsProxyInfo, nsHostRecord, nsHostResolver, nsMappedAttributes, nsHTMLStyleSheet, nsSVGCoordCtxHolder.

Adding a non implemented destructor to nsCOMPtr seems the solution in analogy with bug 209667. I did try this patch on a custom build: warning were gone and build was fine but I'm not 100% sure this is the right solution.

Comment 3

[Régis Caspar]

Comment on attachment 211776 [details] [diff] [review]
define a non implemented dtor for nsDeriveSafe

Asking for review.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 211776 [details] [diff] [review]
define a non implemented dtor for nsDeriveSafe

This is OK with me, but I'd like Benjamin to look as well.

Comment 5

[Benjamin Smedberg]

Comment on attachment 211776 [details] [diff] [review]
define a non implemented dtor for nsDeriveSafe

This will break IRIX, I'm afraid.

Really, what I'd like to do is get rid of nsDerivedSafe altogether... I think it has outlived its usefulness and is now just an extra layer of C++ cruft. Dbaron, what do you think?

Comment 6

[Benjamin Smedberg]

Attachment: remove nsderivedsafe, rev. 1

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 332753 [details] [diff] [review]
remove nsderivedsafe, rev. 1

OK.  I've never been crazy about nsDerivedSafe, since it requires extra casts or .get() when static_casting an nsCOMPtr to a more-derived class; we should probably file a followup bug on finding and removing those...

Comment 8

[Benjamin Smedberg]

Pushed to mozilla-central, revision 2cdac4c2a023

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080811184452 Minefield/3.1a2pre] (home, optim default) (W2Ksp4)

V.Fixed

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> we should probably file a followup bug on finding and removing those...

I filed bug 450127...