279245 - Conflicting shortcuts: Ctrl+N has two meanings

Status: RESOLVED WORKSFORME

(Mozilla Localizations :: Other, defect)

Description

[jayup]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.7.5) Gecko/20041108 Firefox/1.0

In es-AR Windows version, "Edit: Find Again" and "File: New Window" menus
entries shows CTRL+N as keyboard shortcut.
http://www.mozilla.org/support/firefox/keyboard.html tells Find Again is CTRL+G
or F3 in Windows; while F3 works ok, CTRL+G does nothing and CTRL+N opens a new
window.

Reproducible: Always

Steps to Reproduce:
1. Find some text in page. 
2. Press F3, works right.
3. Press CTRL+G, does nothing.
4. Press CTRL+N, opens new window.



Expected Results:  
Should work on CTRL+G, and reflect that association in menu.

Comment 1

[Aaron Leventhal]

Accelerators (ctrl+letter) should not be localized. They should remain the same
no matter what language is being used. For example, Ctrl+G is always next match,
and Ctrl+N is always new document.

Only underlined accesskey mnmemonics should be localized.

Comment 2

[Aaron Leventhal]

I'm wondering if there's some way of preventing these things in the future, or
some kind of warning we ought to provide when someone tries to localize an
accelerator.

Comment 3

[[e-mail]]

(In reply to comment #1)
>Accelerators (ctrl+letter) should not be localized.
If that's really true we then they should not be in locale, should they?
Maybe we need to rip them all out and inline them in the original XUL, i.e.
<key id="key_findAgain" key="G" modifiers="accel" command="Browser:FindAgain"/>

Comment 4

[Aaron Leventhal]

(In reply to comment #3)
> (In reply to comment #1)
> >Accelerators (ctrl+letter) should not be localized.
> If that's really true we then they should not be in locale, should they?
> Maybe we need to rip them all out and inline them in the original XUL, i.e.
> <key id="key_findAgain" key="G" modifiers="accel" command="Browser:FindAgain"/>

Yes. Similarly, I was extremely surprised to see all the duplicate code for
handling Ctrl+W to close window (another key which which should not be
localized). I think we need an attribute in <window> or <dialog> which says
whether the close window accelerator should work.

Comment 5

[Oscar Manuel Gómez Senovilla]

Don't confuse es-ES with es-AR. If necessary, create a separate component.

Please don't assign me es-AR bugs.

Comment 6

[Aaron Leventhal]

Jshin, smontagu -- what is an example of a localization where we might need to
change accelerators to use a different letter? Or is accel+C always copy, and
accel+W always close window?

Comment 7

[Jungshik Shin]

Perhaps, we have to ask around in n.p.m.l10n group. 

Comment 8

[Gintautas Grigas]

Some command key letters are language neutral and widely used, e. g. X in
Ctrl+X, V in Ctrl+V. I do not see any reason to change them during localization.
Some command key letters have English mnemonics and are widely used in other
programs for the same purpose, e. g. C in Ctrl+C for Copy. To change them or not
depends on usage in other localized programs for particular language.
Many command key letters do not have uniform usage. There are no any reason to
prevent to choose them as appropriate. Thus decision to change or not to change
for each keyletter is reasonable to leave for localizers.

Comment 9

[Aaron Leventhal]

After the thread in the l10n newsgroup, and the last poster's comment, I still
see no example of whre ctrl/cmd global command keys should ever change based on
the localization. The consensus in the discussion was we should take these out
of the localization files to prevent future accidental localization of those keys.

Here's the thread:
http://groups-beta.google.com/group/netscape.public.mozilla.l10n/browse_thread/thread/df3affe36bd789aa/6e9299729a4dd42d?q=279245+mozilla&_done=%2Fgroups%3Fq%3D279245+mozilla%26qt_s%3DSearch+Groups%26&_doneTitle=Back+to+Search&&d#6e9299729a4dd42d

Comment 10

[jayup]

I've followed closely this and the Google thread... it's not only annoying
variations between localizations, "giants" also changes commandkeys between
versions!
At least, if customizable, let standard commandkey set as default. Thanks :)

Comment 11

[Axel Hecht [:Pike]]

Mass resolving old l10n bugs. These didn't change since 2006, WORKSFORME.