279263 - Changing Days Off setting doesn't change colors in calendar

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[igor_khanin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20050111 Mozilla Sunbird/0.2RC2

After changing the setting "Day(s) Off Each Week" in Sunbird's options dialog,
the  yellow-ish background color stays in the original days-off (Saturday and
Sunday) and doesn't move to the selected days.

Reproducible: Always

Steps to Reproduce:
1. Go to Tools->Options->Views
2. In General, change the checkboxes to designate other days
3. Confirm

Actual Results:  
Saturday's and Sunday's background stay yellow-ish, and the newly selected days'
backroumd doesn't turn yellow-ish (That is, nothing changed).

Expected Results:  
Remove the background color from the previous days-off and move it to the new
days-off.

Comment 1

[gekacheka]

Attachment: monthView, mutliweekView, weekView patch to use isDayOff to mark weekend days

(patch -l -p 2 -i file.patch)

monthView, multiweekView: 
o Always find preferred days off
o Use them to determine which day boxes to mark as weekend days.

weekView: 
o Always find preferred days off
o Use them to determine which day columns to mark as weekend days.

*/calendar.css
o Add css for week view column background
o Remove week view hour background
o Make background color slightly darker (#FFF9EF -> #FFF9E7)
  as original color appears white on some (LCD) screens.

Tested on 0.2 build for now, can test on nightly trunk build after it becomes
available.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in (plus some whitespace changes)

Comment 3

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!