279278 - Potential memory leak in nsImapServerResponseParser

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Martin Gerbershagen]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a6) Gecko/20050118
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a6) Gecko/20050118

In file nsImapServerResponseParser.cpp, line 369 the memory allocated by
PL_strdup(currentCommand) is not always deleted. If the right side of the && 
in the condition 
if (copyCurrentCommand && !fServerConnection.DeathSignalReceived())
is false, the block is not executed and then the PR_Free(copyCurrentCommand); in
line 387 is never called.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Hans-Andreas Engel]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp&rev=1.118&root=/cvsroot#369

Comment 2

[Hans-Andreas Engel]

Somewhat related, another variable with the same name |copyCurrentCommand| could
be freed even if it was null.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp&rev=1.118&root=/cvsroot#208

Comment 3

[Hans-Andreas Engel]

Attachment: properly freeing copyCurrentCommand in nsImapServerResponseParser

fixes the two issues mentioned above

Comment 4

[Hans-Andreas Engel]

Attachment: properly freeing copyCurrentCommand, better patch (checked in)

Comment 5

[David :Bienvenu]

Comment on attachment 195336 [details] [diff] [review]
properly freeing copyCurrentCommand, better patch (checked in)

looks good, thx.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 195336 [details] [diff] [review]
properly freeing copyCurrentCommand, better patch (checked in)

Patch Checked in:
/cvsroot/mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp,v  <-- 
nsImapServerResponseParser.cpp
new revision: 1.126; previous revision: 1.125
done