279389 - Notify AMO admins by email when internal site errors are encountered

Status: VERIFIED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[Alex Sirota (iosart)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

UMO admins should receive email notifications when the site encounteres internal
problems, so the problems can be quickly solved. 



Reproducible: Always

Comment 1

[Alex Sirota (iosart)]

Attachment: hooked page_error

page_error will send an email notification when error encountered and the
referer is UMO.

Comment 2

[alanjstr]

Comment on attachment 172110 [details] [diff] [review]
hooked  page_error  

You made the comment yourself.	We need to have a "send email" function. 
Separate the code into something like sendemail.php.

Don't assume that all user listed as Admin are sysadmins.  We will need a
designated email address for this.  Perhaps our mailing list.

Comment 3

[Alex Sirota (iosart)]

page_error is a global function
it needs to call send_error_notification, which in turn has to call send_mail.
How can "send_mail" be made not global?

Comment 4

[Alex Sirota (iosart)]

Attachment: global send_mail_message function

1. added a global send_mail_message function
2. this function is called from page_error to send a notification to a pre
defined group of users.
3. changed all the mail_*.php files to use the global send_mail_message
4. fixed a (new) bug in mail_approval.php (wrong email field name)

Comment 5

[alanjstr]

Comment on attachment 172142 [details] [diff] [review]
global send_mail_message function

>+function send_mail_message($to_address, $subject, $body) {
>+  global $site_email_name,  $site_email_address;
>+
>+  $headers .= "MIME-Version: 1.0\r\n";

You start off by concatenating.  Shouldn't it just be $headers = "MIME... 

>+  $headers .= "Content-type: text/plain; charset=iso-8859-1\r\n";
>+  $headers .= "From: ".$site_email_name." <".$site_email_address.">\r\n";
>+  $headers .= "X-Priority: 3\r\n";
>+  $headers .= "X-MSMail-Priority: Normal\r\n";
>+  $headers .= "X-Mailer: Mozilla Update Mail System 1.0";

Before you send the mail, we should check to make sure these values are not
blank

>+  mail($to_address, $subject, $body, $headers);
>+}	

Other than that, nothing catches my eye.

Comment 6

[Alex Sirota (iosart)]

Attachment: send_mail_message take 2

> You start off by concatenating.  Shouldn't it just be $headers = "MIME... 
Heh, just copied this as is from the old code, didn't notice the bug.

> Before you send the mail, we should check to make sure these values are not
blank
Done.

Comment 7

[alanjstr]

Comment on attachment 172162 [details] [diff] [review]
send_mail_message take 2

You can carry this R+ forward.	Just add in a comment explaining the stream
capture.

Comment 8

[Alex Sirota (iosart)]

Attachment: Added a comment on ob_start

Comment 9

[alanjstr]

Has this patch bitrotted?

Comment 10

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 11

[Cameron]

Bugspam makes us be-come druggies
Fa-la-la-la-la, la-la-la-la
Get morgamic some more coffee
Fa-la-la-la-la, la-la-la-la

Updating all the bugs which have "Update" or "UMO" in them.

Comment 12

[Mike Shaver (:shaver emeritus)]

Back in the triage bucket -- I would definitely like this for Remora, I'll say.

Comment 13

[Basil Hashem [:baz]]

Nagios is currently used to monitor and send notification to the IT/Ops team. AMO admins should monitor #bmo to see these alerts.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; Nagios all the way.