279447 - nsSchemaValidator.cpp build failure on Solaris due to missing cast

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Mitch]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a6) Gecko/20050103
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a6) Gecko/20050103

Build on Solaris fails due to missing cast:


/share/lang/solaris/7.0/SUNWspro/bin/CC
-I/share/cprbld/users/scratch/mitch/mozilla/support/include -o
nsSchemaValidatorUtils.o -c  -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\"
-DHAVE_DEPENDENT_LIBS  -I../../../dist/include/xpcom
-I../../../dist/include/string -I../../../dist/include/dom
-I../../../dist/include/xpconnect -I../../../dist/include/caps
-I../../../dist/include/widget -I../../../dist/include/unicharutil
-I../../../dist/include/content -I../../../dist/include/js
-I../../../dist/include/necko -I../../../dist/include/xmlextras
-I../../../dist/include/websrvcs -I../../../dist/include/schemavalidation
-I../../../dist/include
-I/share/cprbld/users/scratch/mitch/mozilla/mozilla/dist/include/nspr	    -I.	 
 -KPIC   -I/share/cprbld/users/scratch/mitch/mozilla/support/include
-xbuiltin=%all -features=tmplife -mt  -DNDEBUG -DTRIMMED -O  
-DMOZILLA_VERSION=\"1.8b\" -DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1
-DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1
-DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1
-DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1
-DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1
-DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1
-DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1
-DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1
-DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1
-DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_BUILD_APP=suite
-DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_COREXFONTS=1
-DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1
-DHAVE_GSSAPI_GSSAPI_H=1 -DHAVE_GSS_C_NT_HOSTBASED_SERVICE=1 -DMOZ_MATHML=1
-DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILESHARING=1
-DMOZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1
-DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1
-DMOZILLA_LOCALE_VERSION=\"1.8b\" -DMOZILLA_REGION_VERSION=\"1.8b\"
-DMOZILLA_SKIN_VERSION=\"1.5\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT
nsSchemaValidatorUtils.cpp
"nsSchemaValidator.cpp", line 2056: Error: Cannot assign const char* to char*.
1 Error(s) detected.
gmake[5]: *** [nsSchemaValidator.o] Error 1
gmake[5]: Leaving directory
`/share/cprbld/users/scratch/mitch/mozilla/mozilla/extensions/schema-validation/src'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory
`/share/cprbld/users/scratch/mitch/mozilla/mozilla/extensions/schema-validation'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory
`/share/cprbld/users/scratch/mitch/mozilla/mozilla/extensions'
gmake[2]: *** [tier_94] Error 2
gmake[2]: Leaving directory `/share/cprbld/users/scratch/mitch/mozilla/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/share/cprbld/users/scratch/mitch/mozilla/mozilla'
gmake: *** [build] Error 2

~



Reproducible: Always

Steps to Reproduce:

Comment 1

[Mitch]

Changing line 2056 from

      pch = strchr(strValue.get(),'T');

to the correct cast

      pch = (char *) strchr(strValue.get(),'T');

fixes the build failure.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

seems like a better way to fix it would be to change the decl of pch to const char*

Comment 3

[Doron Rosenberg (IBM)]

I assume you are building MOZ_EXTENSIONS_ALL?

If someone posts a patch I'll check it in.  Note that the latest patch waiting
for review moves everythign to mozilla strings.

Comment 4

[Mitch]

Yup, building with extensions all (configure --enable-extensions).

If there's a pending patch to move to mozilla strings, then let's just defer
this patch. The fix is obvious, so can be manually patched till then. I'm ok to
close this.

Comment 5

[Doron Rosenberg (IBM)]

Its your choice.  I'd be happy to check in the suggestion in
https://bugzilla.mozilla.org/show_bug.cgi?id=279447#c2 if it fixes solaris.

Comment 6

[Mitch]

Attachment: Patch as per comment 2

Thanks Doron for checking in.

Comment 7

[Mitch]

Attachment: Updated patch

New patch. I patched my patched version in the previous diff.

Comment 8

[Doron Rosenberg (IBM)]

checked in.