279510 - Remove TARGET_CARBON from widget/src/mac and gfx/src/mac

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[Peter Van der Beken [:peterv]]

We only support OS X anyway.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: nsMacWindow

I personally don't have time right now to go through all of them. Here's what I
had laying around already.

Comment 2

[Ludovic Hirlimann [:Usul]]

Attachment: remove TARGET_CARBON in gfx/src/mac

I'll do the clean up directory by directory.
First patch cleans up /fgx/src/mac, to finish the clean up the following files
needs to be cvs removed :
nsPrintSettingsMac.{h|cpp}
nsPrintOptionsMac.{h|cpp}
nsDeviceContextSpecMac.{h|cpp}

Asking r to pink.

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 172478 [details] [diff] [review]
remove TARGET_CARBON in gfx/src/mac

Looks good although CurrentPortIsWMPort() could probably just go away.

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: remove TARGET_CARBON from widget/src/mac

second directory that is cleaned up. files
nsMenuBar.{h|cpp}
nsMenu.{h|cpp}
nsMenuItem.{h|cpp}
Can be cvs removed.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 172478 [details] [diff] [review]
remove TARGET_CARBON in gfx/src/mac

r=pink

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 172494 [details] [diff] [review]
remove TARGET_CARBON from widget/src/mac

+#if (UNIVERSAL_INTERFACES_VERSION >= 0x0330)

is this even still needed? we use this in a couple of places.

r=pink

Comment 7

[Simon Fraser [no longer active]]

Changes are in, with a bit more cleanup including the
UNIVERSAL_INTERFACES_VERSION stuff. Thanks Ludovic!

Comment 8

[Hiro]

widget/src/mac/nsCheckButton.cpp seems not to be used. 
In Firefox and Camino, this source is not compiled. 

Is this used in another place?

Comment 9

[Simon Fraser [no longer active]]

There are a number of native widget classes in widger/src/mac that are unused. I
kept them around in case we want to revive native widgets at some point, but
maybe we should just remove them. Mike?

Comment 10

[Mike Pinkerton (not reading bugmail)]

if we revive "native widgets" i think it should be through the same xbl-linked
mechanism as we do native scrollbars, in which case they won't be nsIWidgets.
Those unused ones can prolly all go.

Comment 11

[Hiro]

Thank you for the comment, Mike-san,Simon-san.
And I agreed.

Comment 12

[Simon Fraser [no longer active]]

I removed those old native wiget files.