Closed Bug 279541 Opened 19 years ago Closed 19 years ago

Possible error in copy-paste of new code (pripv6.c)

Categories

(NSPR :: NSPR, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: wtc)

References

()

Details

Attachments

(1 file)

See http://bonsai.mozilla.org/cvsblame.cgi?
file=mozilla/nsprpub/pr/src/io/pripv6.c&rev=3.11&root=/cvsroot&mark=330,331,333
,334,342,343,345,346#321

The duplicate code should either be removed or amended to read: 
ipv6_to_v4_udpMethods.* rather than ipv6_to_v4_tcpMethods.*

Reading Bonsai notes this exists on the stable branch of 
[NSPRPUB_RELEASE_4_0_20000223], not-verified as of yet.
Thanks for the bug report.  Those four lines
should say ipv6_to_v4_udpMethods.*
rather than ipv6_to_v4_tcpMethods.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → 4.6
Attached patch Proposed patchSplinter Review
Fix the errors in code that was copied and pasted.

Darin, please review this patch.

Justin, how did you discover this bug?
Attachment #172266 - Flags: review?(darin)
I discovered it by manually tracing my way through the nspr init for my build
(to better understand the code behind all my stuff), been doing that in my spare
time.

It was not affecting my work (as far as I am aware) but noticed it and figured a
Bug would be great ;-)
Comment on attachment 172266 [details] [diff] [review]
Proposed patch

r=darin
Attachment #172266 - Flags: review?(darin) → review+
Patch checked into the NSPR trunk (NSPR 4.6)
and NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.8 Beta).
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: