279587 - documentation referred to in nsDragAndDrop.js does not exist

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Jussi Kukkonen]

Both mozilla/xpfe/global/resources/content/nsDragAndDrop.js and
mozilla/source/toolkit/content/nsDragAndDrop.js contain this comment:

/**
 * nsDragAndDrop - a convenience wrapper for nsTransferable, nsITransferable
 *                 and nsIDragService/nsIDragSession. 
 *
 * USAGE INFORMATION: see 'README-nsDragAndDrop.html' in the same source directory
 *                    as this file (typically xpfe/global/resources/content)
 */

the html file that's mentioned does not exist. Comment should be removed or
(preferably) the mentioned document should be created.

I'm CCing Ben, since he's the one who replaced the original "documentation" with
that comment (this happened in revision 1.15).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like Ben forgot to check in the documentation...

Reporter, would you mind creating a patch to add that information (from the CVS
log) to either the file where it used to be or as an HTML file like Ben was
planning to do?

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch (undo changes from version 1.15)

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Is there a reason the XPFE file still says:

////////////////////////////////////////////////////////////////////////////
// XXX - WARNING - DRAG AND DROP API CHANGE ALERT - XXX
// This file has been extensively modified in a checkin planned for Mozilla
// 0.8, and the API has been modified. DO NOT MODIFY THIS FILE without 
// approval from [e-mail], otherwise your changes will be lost. 

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 173443 [details] [diff] [review]
patch (undo changes from version 1.15)

r=[e-mail]

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in