Closed Bug 279634 Opened 20 years ago Closed 19 years ago

Can't enable an extension immediately after disabling it

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: marcia, Assigned: bugs)

References

Details

Found using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0.

STR:

1. Install an extension
2. Disable that extension. Change your mind, decide you want to re-enable.
3. Can't, that option is grayed out when you click the extension. Sad :(

Works on Windows - you should be able to toggle back and forth between disable
and enable if you change your mind. We should fix this for the next release so
we are consistent.
marcia, did you restart firefox btwn step 1 and 2?

I can repro this problem on linux fc2 (2005012407-trunk), but then again it was
with an extension that was installed *and* after I had restarted ffox.
actually, here's what happened for me:

a. extension enabled -> disabled -> unable to re-enable

b. extension disabled -> enabled -> able to re-disabled (and also re-enable, ad
nauseaum)
Did  not restart. Interestingly enough, the first time I right clicked on the
extension enable was grayed out - when I revisited Firefox after doing some
other things it was no longer grayed out. Guess I need to  play around with this
some more.
Here is some additional information:

Windows behavior:
I installed the Calendar extension on Windows. I then disabled it. I am then
able to re-enable it, and switch back and forth between the two *without*
restarting FF.

On the Mac, whenever I switch to either disable or enable, the option is grayed
out when I am ready to switch back.  If I change focus to another area outside
of the browser, then the disable/enable option can be selected. Weird.
hm, I'm running into a similar problem using Adblock with 2005052505-trunk (deer
park) on linux fc3.

1. installed Adblock v0.5.2.039 from UMO without any problems.

2. restarted ffox. was able to successfully block out ads (images and iframes).

3. went into Extension manager, disabled Adblock. restarted ffox.

4. go back into Extension manager, attempt to enable Adblock, and I get the
following in the dialog: "Disabled - not compatible with Deer Park 1.0+"

didn't see errors in the JS console --why is this happening when initially the
extension had worked?

is this:

a. a problem with the version of ffox trunk at the moment?
b. a problem with the Adblock extension itself?
c. a problem with UMO?
d. something else?

let me know if I should spin off a separate issue for what I'm seeing.
Flags: blocking-aviary1.1?
Hardware: Macintosh → All
Summary: [Mac only] Can't enable an extension immediately after disabling it → Can't enable an extension immediately after disabling it
*** Bug 295166 has been marked as a duplicate of this bug. ***
Bug 295166 seems to indicate that the problem is that the state of the context
menu is not updated right until the extension loses and regains focus in the
extension manager.
I am very sure that the desired behavior will be provided by the patch in bug 284515
Depends on: 284515
When installing an extension a restart must be performed first before it can be
disabled since it isn't in the extensions datasource yet so disable and enable
will be greyed out. Now that the patch for bug 284515 has landed you should be
able to enable and disable repeatedly during one session. Also, if it is
disabled, you select enable, and then select disable it will just cancel the
enable action and not attempt to enable it during the next restart. The same
goes for enable > disable > enable.
Marcia, are you experiencing this in recent trunk builds?
Using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2)
Gecko/20050603 Firefox/1.0+ on the Mac, I am now able to disable an extension,
and then re-enable it if I change my mind. That was the original behavior I was
trying to correct when I filed this bug, thinking that end users might make a
mistake and change their mind, and not want to have to restart in order to get
the extension re-enabled.
marking w4m per comment 11.
Status: NEW → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.1?
Resolution: --- → WORKSFORME
Reopening: I am still this bug with Mac DP build 2005-06-06-07-trunk

disabling an extension greys out the context menu selection for enable until restart.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Tracy - does the extension in the extension manager become greyed out
immediately as well when you select disabled?
No, the extension doesn't become greyed out until restart.
This WFM with 20050607 atlantia tinderbox build on Mac OS X.
marcia and tracy, I wonder if this is still occurring for you because you're
using a profile that was created with a recent trunk build which might've lacked
some other recent checkins specifically for extensions.

here's why:

a. when I created a profile with ffox 1.0.4 (but didn't install any extensions),
then restarted with 2005060907-trunk (deer park), I was able to disable and
re-enable over and over again. I tested on the DOM Inspector, which recently
became a real extension listed in the Extensions manager.

b. when I created a profile using 2005060907-trunk, I was also able to disable
and re-enable DOM Inspector over and over again.

c. I got somewhat similar results with a variation of (a), where I installed
Adblock and PDF Download in ffox 1.0.4 (and restarted ffox 1.0.4 to ensure
they're fine). I then restarted the same profile with 2005060907-trunk and was
able to disabled and re-enable DOM Inspector and PDF Download over and over
again. The only problem I saw there was that Adblock was labeled as incompatible
with 1.0+ (when launched in 2005060907-trunk) --I'm not sure if that's an issue
specific to Adblock, since bug 293416 and bug 267906 have already been fixed--
especially considering what I saw in the next scenario, (d) below...

d. I got the same results with a variation of (b), where I also installed (and
then restarted with) Adblock (no incompatibility issues) and PDF Download
extensions, using a 2005060907-trunk created profile. I was able to disable and
re-enable those 2 extensions and DOM Inspector, over and over.
(In reply to comment #17)
> specific to Adblock, since bug 293416

typo: meant to say bug 293419.
WFM with Deer Park builds:
Windows 2005-07-01-06-trunk
Mac 2005-07-01-07-trunk
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → WORKSFORME
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.