Closed
Bug 279645
Opened 20 years ago
Closed 20 years ago
New Download prefs need to be included in HELP.
Categories
(Documentation Graveyard :: Help Viewer, defect)
Documentation Graveyard
Help Viewer
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: patrick.hendriks+bugzilla, Assigned: stefanh)
References
Details
Attachments
(1 file, 3 obsolete files)
3.79 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
The new download prefs from the pref window are not included in HELP yet. 1) "When saving a file" 2) "When a download completes" Since at least the first one is mentioned in the Moz 1.8 release notes under "what's new" i guess they should be included before 1.8 is released. Couldn't find this yet... Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050115
Comment 1•20 years ago
|
||
*** Bug 279644 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•20 years ago
|
Component: Help → Help Viewer
Product: Mozilla Application Suite → Documentation
Version: Trunk → unspecified
Assignee | ||
Comment 2•20 years ago
|
||
Yes, we should fix this before 1.8b is released...
Assignee: neil.parkwaycc.co.uk → help.viewer
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•20 years ago
|
||
Assignee | ||
Comment 4•20 years ago
|
||
Assignee: help.viewer → stefan_h
Attachment #172651 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•20 years ago
|
||
OK, I see if I can polish the patch on Sunday. My imagination seems gone today... Feedback is welcome!
Target Milestone: --- → mozilla1.8beta
+ use.To listen to the sound you've chosened, click Preview.</li> space between "use." and "To". "chosened" = "chosen"
Assignee | ||
Comment 7•20 years ago
|
||
Thanks for catching those ugly errors, Patrick. Fixed a few oddities in mail_help as well.
Attachment #172690 -
Attachment is obsolete: true
Attachment #172882 -
Flags: review?(bugzilla)
Comment on attachment 172882 [details] [diff] [review] Final version >Index: resources/locale/en-US/cs_nav_prefs_navigator.xhtml >+ <li><strong>Play a sound</strong>: Select this if you want >+ &brandShortName; to play a custom sound (in WAW format) when a download I would suggest changing the bit in brackets to: (typically in WAV format) as Windows do WAVs but other platforms (well Macs) can play other formats. >+ is completed. Enter the path to the sound file or use the Browse button >+ to select it in the file locator. To listen to the sound you've >+ chosen, click Preview.</li> This is incorrect as the text field is read only so currently you can only browse to the sound file - it may change later but the help will have to change at that point. >Index: resources/locale/en-US/mail_help.xhtml > You can choose between the default system sound and a custom sound in > WAV format. If you choose the latter you have to enter the path to the >-sound file or use the Browse button to select in in the file locator. >-Click on the Preview button to preview the choosen sound file. >+sound file or use the Browse button to select it in the file locator. >+Click on the Preview button to listen to the chosen sound file. As above, WAV format again (though the prefs text mentions .wav incorrectly - so perhaps leave in and log the changing of ".wav" to "sound" as a new bug and alter the help then) and text field is read only so can only browse. With those changes r=me
Attachment #172882 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 9•20 years ago
|
||
New version addressing Ians comments. I left the WAV stuff untouched in mail_help and changed the copyright line in the two altered files. Can you check in the patch, please?
Attachment #172882 -
Attachment is obsolete: true
Comment 10•20 years ago
|
||
Comment on attachment 172903 [details] [diff] [review] New version (checked in) Checking in cs_nav_prefs_navigator.xhtml; /cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_navigator. xhtml,v <-- cs_nav_prefs_navigator.xhtml new revision: 1.25; previous revision: 1.24 done Checking in mail_help.xhtml; /cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v <-- mail_help.xhtml new revision: 1.51; previous revision: 1.50 done
Attachment #172903 -
Attachment description: New version → New version (checked in)
Attachment #172903 -
Flags: review+
Assignee | ||
Comment 11•20 years ago
|
||
thx Ian!
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•