There's at least one in toolkit/content that I know. This is mostly comm.jar refugees, but we should fix these.
Assignee: firefox → mconnor
Status: UNCONFIRMED → NEW
Ever confirmed: true
this is about 40k of bits to strip, I'll fix these before 1.1
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.1
See also bug 68686.
Created attachment 193495 [details] [diff] [review] Patch for 10 of the files (in browser and toolkit only) It looks like EXTRA_PP_COMPONENTS is exactly the same as EXTRA_COMPONENTS except each component is preprocessed; if this is wrong I'll need to redo a little bit of the patch. I haven't built this, but I double-checked that I covered all the relevant places to tweak to get all the changed files preprocessed (when a file wasn't already preprocessed).
Assignee: mconnor → jwalden+bmo
Attachment #193495 - Flags: review?(mconnor)
These should probably use the new boilerplate suggested by bsmedberg, which have the advantage of being (mostly) preprocessed out in addition to being valid JS files. http://gavinsharp.com/tmp/license-boilerplate.txt
(In reply to comment #6) The fact that the files may not be otherwise valid doesn't excuse making them invalid, and there is no requirement to include the license header at the top of each file when it's shipped as an "executable" in a jar. See bug 68686.
That's true. So this (and bug 309418; dupe?) should be fixed by adding/replacing each file's boilerplate with one that gets preprocessed out, yet doesn't invalidate the file (at least, not more than it may already be) before preprocessing? That should be easy enough, but I think we have to wait for firstname.lastname@example.org (according to email@example.com in bug 279215) to approve (i.e. is it OK to not have the terms in each file, and if so, in how many places do the terms have to be? Top level, each directory etc.) Why not have the comment delimiters outside the LICENSE BLOCK, rather than on the same line? That would reduce the size slightly more, and not leave an empty license block, but rather no block at all.
Attachment #193495 - Flags: review?(mconnor) → review+
(Blast from the past!) Patch checked in, with appropriate un-bitrotting tweaks (mostly for components which had already been switched to being preprocessed). I didn't change the license format to a more JS-friendly format; someone else can do that if they care, but I don't see it as a huge issue. There are still more files to change, so this bug remains open.
Created attachment 258907 [details] [diff] [review] unbust SeaMonkey cookie dialog
Attachment #258907 - Flags: review?(neil)
Comment on attachment 258907 [details] [diff] [review] unbust SeaMonkey cookie dialog I still fail to understand toolkit's obsession with .jar size ...
Attachment #258907 - Flags: review?(neil) → review+
Comment on attachment 258907 [details] [diff] [review] unbust SeaMonkey cookie dialog (landed)
Attachment #258907 - Attachment is obsolete: true
footprint key word?
Per bug 309418, the new license headers are not large enough for this to matter.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.