27970 - Weird black dotted lines around marked link image

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Henrik Gemal]

If you go to:
http://www.gemal.dk/browserspy/screen.html
and mark the image "Back" but dont press it you'll see that the appears two 
dotted squares. One is around it and the other is inside it.
Please see attached image.

Expected:
This inside dottes square shouldn't be there!

Comment 1

[Henrik Gemal]

Attachment: Two dotted sqaures

Comment 2

[troy]

Rod, this looks like the code that draws the dotted border aroundthe element 
with focus

Comment 3

[rods (gone)]

The smaller (shorter) dotted line is for the link and this is sized incorrectly 
and may be a separate bug. The issue here is that the anchor or link has a style 
rule and there is also a style rule for an image inside of a link.

Here is a dump of the frames (for an testcase I will attach):

line 01FF58F0: count=1 state=block,,,[0x402] {120,120,15120,570} 
ca={120,120,15120,630} <
  Block(body)(2)@00DEA864 {120,120,15120,570} [state=0000000c] 
sc=01FF5BB0(i=1,b=0)<
    line 01FE5CE0: count=1 state=inline,,,[0x400] {0,0,2400,570} 
ca={0,0,2400,630} <
      Inline(a)(0)@00DEA8AC {0,345,2400,285} [state=0000001c] sc=01FF7780<
        Frame(img)(0)@00DEA8E4 {0,-345,2400,570} [state=000000b4]
      >
    >
  >
>

Note above how the line height is correct but the anchor frame has the wrong 
size and therefore the image has a negative offset, this seems wrong.

Also, I am not sure we need the style rule for when an img tag is inside a 
"link", the link rule should be enough.

Comment 4

[rods (gone)]

Attachment: simplified example

Comment 5

[rods (gone)]

The fact that the link and img/link are using the "outline" style is a different 
issue, the bug here is the anchor frame is the wrong size and there is a 
question as to whether we really need the ":link img" rules.

Assigning to buster, although it could be a troy issue, or whoever should go fix 
the anchor frame's layout.

Comment 6

[Nicolas Lhommet]

Attachment: pretty simplified testcase :)

Comment 7

[Nicolas Lhommet]

Yes, i've heard a lot web developers complaining about those dotted lines 
around image in a link. They appeared in M14, but Internet Explorer 5 has the 
same feature. When you want to get a kind of artistic web page, with mouse 
events on a lot of layers or rollover images with links, you don't like to see 
those dotted lines appearing anyway.
PLEASE, DON'T KEEP THOSE UGLY AND USELESS DOTTED LINES.
A lot of people and me would be very grateful to you for removing them before 
the official release.

Comment 8

[buster]

rod, kevin: do either of you know anything about this issue?

Comment 9

[rods (gone)]

What aspect? Getting rid of the dotted lines, or the part about the original 
bug?

Comment 10

[buster]

rod: both

Comment 11

[Henrik Gemal]

Seems to be fixed in 2000061820

Comment 12

[Chris Petersen]

Fixed in the July 6th build.