If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Error mapper not called for PR_ReadDir implementation

RESOLVED FIXED in 4.6

Status

NSPR
NSPR
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Mathieu Poumeyrol, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041007 Debian/1.7.3-5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041007 Debian/1.7.3-5

When PR_ReadDir reach the end of a directory, it returns NULL (which is fine)
but forget to call the error mapper pt_MapError to set correct error codes.

Reproducible: Always
(Reporter)

Comment 1

13 years ago
Created attachment 172338 [details] [diff] [review]
Patch proposal to solve the issue

This short patch seams to solve the issue. A little bit unsure about the right
way to call the mapper (MT / errno / ...).
(Assignee)

Comment 2

13 years ago
Comment on attachment 172338 [details] [diff] [review]
Patch proposal to solve the issue

r=wtc.	This patch is correct.	Thanks for the bug report
and patch.
Attachment #172338 - Flags: review+
(Assignee)

Comment 3

13 years ago
Patch checked into the NSPR trunk (NSPR 4.6) and
NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.8 Beta).
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.6
You need to log in before you can comment on or make changes to this bug.