279748 - Move GetFieldDefs out of globals.pl (to Bugzilla::DB)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

I'm going to move the GetFieldDefs function to Bugzilla::Bug. I'm also going to
make it stop using SendSQL calls, while I do that.

Comment 1

[Max Kanat-Alexander]

Attachment: Move GetFieldDefs and change to use DBI

OK. It uses DBI, and it's now in Bugzilla::Bug. I tested the two places where
it's used (it's very simple to test) and they still work.

I also added some pod documentation for it.

Comment 2

[Vlad Dascalu]

Comment on attachment 172344 [details] [diff] [review]
Move GetFieldDefs and change to use DBI

+  my @fields = GetFieldDefs();

Shouldn't that be Bugzilla::DB::GetFieldDefs()? First because it's not exported
by default in the package, and secondly because the "# Connection" section
which is right above it uses it.

Otherwise looks good. If you agree it's a good thing, it can be fixed upon
check in or if you have the time you can make a new patch and carry my review.

Comment 3

[Max Kanat-Alexander]

Oh yeah, I agree that's a good thing and can just be fixed on checkin.

Comment 4

[Shane H. W. Travis]

Committed... but I lost the checkin messages. :(

... except for this one:

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.16; previous revision: 1.15
done

... because I had to check that file twice; I missed the 'fix on checkin' 
comment initially.