279769 - does not open bookmarks folder in personal toolbar.

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[baffclan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050124
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050124

dos not drop down bookmarks in bookmark on personal toolbar.


Reproducible: Always

Steps to Reproduce:
1. open web page (ex, http:www.mozilla.org/).
2. close personal Toolbar on Browser.
3. view a "Print Preview".
4. close a "Print Preview".
5. open personal Toolbar.
6. click a bokmarks folder on personal toolbar.
7. filder icon is open
Actual Results:  
8. dos not drop down bookmarks in bookmark folder on personal toolbar.

Expected Results:  
8. drop down bookmarks in bookmark folder on personal toolbar.

Comment 1

[baffclan]

Attachment: screen shot

Comment 2

[Boris Zbarsky [:bzbarsky]]

How, exactly, do you do step 2?  Collapse it via the grippy, or turn it off in
the View menu?

Comment 3

[baffclan]

(In reply to comment #2)
> How, exactly, do you do step 2?  Collapse it via the grippy, or turn it off in
> the View menu?
It is via the grippy.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm.. worksforme in a 2005-01-25-06 Linux trunk build...

Comment 5

[baffclan]

(In reply to comment #4)
> Hmm.. worksforme in a 2005-01-25-06 Linux trunk build...
this problem is windows only?


I tested new profile.

Steps to Reproduce:
0. make a new profile.
1. open web page (ex, http:www.mozilla.org/).
2. close personal Toolbar via groppy.
3. view a "Print Preview".
4. close a "Print Preview".
5. open personal Toolbar.
6. click a bokmarks folder on personal toolbar.
7. filder icon is open, and drop down bookmarks.
8. close personal Toolbar via groppy.
9. view a "Print Preview".
10. close a "Print Preview".
11. open personal Toolbar.
12. click a bokmarks folder on personal toolbar.
13. filder icon is open, but do not drop down bookmarks.

# I think, this problem is regression. like a Bug 275996.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ok, with the steps in comment 5 I can reproduce.  Note that step 11 requires _2_
clicks on the grippy.  I bet that's the problem....

Comment 7

[[e-mail]]

I see this in my mingw build from 22 Jan. Notes:
The grippy collapses the toolbar (visibility: collapse;)
Print preview hides the toolbar (display: none;)
Removing the menugenerated attribute "fixes" the problem.

Comment 8

[[e-mail]]

Attachment: Proposed patch

This fixes it for me...

Comment 9

[Boris Zbarsky [:bzbarsky]]

I won't be able to review this until I get back into town...

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 177856 [details] [diff] [review]
Proposed patch

r+sr=bzbarsky, but does nsMenuPopupFrame need something similar?

Comment 11

[[e-mail]]

(In reply to comment #10)
>does nsMenuPopupFrame need something similar?
nsPopupSetFrame::DestroyPopup already unsets the menugenerated attribute.

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[baffclan]

Thanks for fixing this.
-> v.