279788 - Autocomplete crashes in mail compose - TBTrunk [@ nsGenericElement::isSelfOrAncestor][@ nsIContent::GetParent - nsGenericElement::isSelfOrAncestor]

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Scott MacGregor]

This was a regression introduced by Bug #279155 last night.

Bring up the compose window. Type in an address with multiple auto complete
matches. Choose a match and hit enter. Application crashes in
nsGenericElement::isSelfOrAncestor. aNode is NULL.

nsIContent::GetParent() line 128 + 3 bytes
nsGenericElement::isSelfOrAncestor(nsIContent * 0x00000000, nsIContent *
0x031ba5f8) line 2669 + 8 bytes
nsXULElement::RemoveChildAt(unsigned int 2, int 1) line 1143 + 23 bytes
nsGenericElement::ReplaceChild(nsGenericElement * const 0x03336cc8, nsIDOMNode *
0x042431c4, nsIDOMNode * 0x031ba614, nsIDOMNode * * 0x0012b954) line 3055 + 17 bytes
nsXULElement::ReplaceChild(nsXULElement * const 0x03336cc8, nsIDOMNode *
0x042431c4, nsIDOMNode * 0x031ba614, nsIDOMNode * * 0x0012b954) line 547 + 24 bytes

Comment 1

[Tobias Fischer]

This Crash occours in Mozilla-Suite MailNews too. Using latest Nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050125
Mnenhy/0.7.1 {Build ID: 2005012506}

Add Talkback Incident: TB3285013K

Think we have to adjust the Bug-Subject to "Thunderbird and MailNews
Autocomplete crashes in mail compose" or similar.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This is all mine, looking...

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I have a patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

GetCurrentItem must be returning null. Either way, this is what the code used
to do.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172381 [details] [diff] [review]
patch to fix

r+sr=bzbarsky

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Scott, please check to make sure that this helped.

Comment 7

[Scott MacGregor]

yeah that fixed it. Thank you for the quick turn around. 

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

awesome, marking verified. Sorry for the regression.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 279873 has been marked as a duplicate of this bug. ***

Comment 10

[Bruce Wolfe]

Does today's build include this fix?

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I guess any build later then 200501251329 should have the fix. I'm not sure when
the nightly builds are made.

Comment 12

[Jay Patel [:jay]]

Adding topcrash info for future reference.

Comment 13

[Anthony Jenkins]

*** Bug 281686 has been marked as a duplicate of this bug. ***