279844 - URLs with relative anchors loaded in new tabs scroll to incorrect location

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Simon Fraser [no longer active]]

If you command-click a link that loads a URL with a relative anchor (e.g. the
one in the URL field), when you click on the newly created tab, the page is
often scrolled to the wrong location. This is annoying.

Comment 1

[Simon Fraser [no longer active]]

The bug happens because when we make a new tab, we don't size the browser view
up-front. When we resize the browser view when you actually click on the tab, we
then lose the scroll position.

Comment 2

[Simon Fraser [no longer active]]

Attachment: Patch

This patch fixes the basic bugs by resizing the BrowserWrapper under two
circumstances:
1. when making new tabs
2. when loading a url into a background tab

The latter required early access to mWindowController, so that is now handed in
at init time, and mIsPrimary checks were added in several other places (which
probably fixes some bugs with background tabs incorrectly messing with window
elements).

Comment 3

[Mike Pinkerton (not reading bugmail)]

patch looks good, maybe next time a little more context in the diff would help
me see it more clearly. i agree on the delegate protocol for BWC, it's such a
mess and needs to be broken up, prolly into a few files.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 192930 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Fraser [no longer active]]

Fix checked in.