Closed Bug 279896 Opened 20 years ago Closed 20 years ago

Update Bugzilla's header and colour scheme to match bugzilla.org

Categories

(Bugzilla :: User Interface, enhancement)

2.19.2
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(4 files, 2 obsolete files)

As discussed on the developer's list, I have CSS only updates that make Bugzilla
match the style of the bugzilla.org website.
Attached patch css changes v1 (obsolete) — Splinter Review
Attachment #172450 - Flags: review?(myk)
Status: NEW → ASSIGNED
I like this, apart from the removal of link underlines in the non-hovered case.

Gerv
Comment on attachment 172450 [details] [diff] [review]
css changes v1

> .. apart from the removal of link underlines

fair enough - i'll do an updated version with that.
Attachment #172450 - Flags: review?(myk)
Attached patch css changes v2 (obsolete) — Splinter Review
this version no longer removes underlines and fixes border display of tabs in
IE
Attachment #172450 - Attachment is obsolete: true
Attachment #173068 - Flags: review?(myk)
Comment on attachment 173068 [details] [diff] [review]
css changes v2

I still have some issues with this patch (f.e. consistent use of sans-serif
font for UI elements, use of graphics for header text), but it's better than
the old style, and we can iterate from here.  r=myk, and thanks for the patch!
Attachment #173068 - Flags: review?(myk) → review+
Flags: approval+
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 173068 [details] [diff] [review]
css changes v2

I received the following errors when trying to apply this patch;

patching file skins/standard/index.css
Hunk #1 FAILED at 40.
patch: **** malformed patch at line 155:

The patch just seems to cut off mid-instruction, so there's no way to guess
what was supposed to be there.

Please re-submit a new patch.
Attachment #173068 - Flags: review-
glob, looks like you only need to remove the last 3 lines of your patch:
@@ -66,4 +66,4 @@
         padding: 1em 0;
     }
Attached patch css changes v3Splinter Review
oops
Attachment #173068 - Attachment is obsolete: true
Comment on attachment 173228 [details] [diff] [review]
css changes v3

carrying forward r+
Attachment #173228 - Flags: review+
Note: Still had to apply the changes to index.css manually, because the file 
was littered with ^M characters, apparently from its initial checkin, and these 
fooled the context-checker so the patch could not be applied.


Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.8; previous revision: 1.7
done
Checking in skins/standard/index.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/index.css,v  <--  index.css
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
The images for this bug have not been checked in.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
All three image files checked in.

As a request: if you aren't going to be the one checking in your changes, and 
there are things that need to be done by the person who IS going to check it 
in -- small mods to make on commit, additional files other than the patch, 
etc. -- please make a comment somewhere (preferably somewhere near the end) to 
that effect. There was no reference to these files anywhere, so when I scanned 
through the comments I missed that they needed to go in too. Thanks!



RCS 
file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/global/body_back.gif,v
done
Checking in skins/standard/global/body_back.gif;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global/body_back.gif,v  <--  
body_back.gif
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/global/header.png,v
done
Checking in skins/standard/global/header.png;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global/header.png,v  <--  
header.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/front.png,v
done
Checking in skins/standard/index/front.png;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/index/front.png,v  <--  
front.png
initial revision: 1.1
done
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: