279950 - tab border on search and prefs pages isn't black in Internet Explorer

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Rob Siklos [:robzilla]]

the tabs in the search and prefs pages look much nicer in Mozilla than in
Internet Explorer.  This is because in Mozilla, the "border" of the tabs is
black, while in IE, it's light gray.

Comment 1

[Rob Siklos [:robzilla]]

Attachment: robzilla_v1

Comment 2

[Rob Siklos [:robzilla]]

Attachment: robzilla_v2

sorry, here's a better-formed patch

Comment 3

[Peter Bittner]

Instead of putting the style declaration into the template file directly I'd
suggest to omit it there completely and move it to web/css/global.css (thus
adding the following lines):

td.selected_tab
{
    border-width: 2px 2px 0px;
    border-style: solid;
    border-color: black;
}
td.unselected_tab, td.spacer
{
    border-width: 0px 0px 2px 0px;
    border-style: solid; 
    border-color: black;
}
dl.bug_changes, dt
{
    margin-top: 15px;
}

Wouldn't that be much better?

This way one could customize the tabs' appearence without having to mess around
in the templates. Modifying web/css/global.css would do it all.

Peter

Comment 4

[Peter Bittner]

(In reply to comment #3)
> Modifying web/css/global.css would do it all.

For the same reason I would remove the "bgcolor=" attributes from the td-tags
that define background-color in td.selected_tab and td.unselected_tab, respectively.

When all such markup (I'd like to address '<font size="+2">' etc. too) is moved
from the template code into the css-files we will sooner or later have a fully
skinnable web application just providing different versions of css-files. -- And
that would *really* be nice!

Cheers, Peter

Comment 5

[Shane H. W. Travis]

Peter Bittner: your ideas and suggestions are worthy of another bug. This one 
solves the problem, albeit not in what you perceive to be the most elegant way, 
so it's being checked in for now.


Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.
tmpl,v  <--  prefs.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/search/search-advanced.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-
advanced.html.tmpl,v  <--  search-advanced.html.tmpl
new revision: 1.23; previous revision: 1.22
done