Closed
Bug 279955
Opened 20 years ago
Closed 16 years ago
remove CurrentPortIsWMPort()
Categories
(Core Graveyard :: GFX: Mac, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Usul, Unassigned)
References
()
Details
Attachments
(1 file)
|
872 bytes,
patch
|
mikepinkerton
:
review-
sfraser_bugs
:
superreview-
|
Details | Diff | Splinter Review |
.
|
Reporter | |
Comment 1•20 years ago
|
||
Attachment #172747 -
Flags: superreview?(sfraser_bugs)
Attachment #172747 -
Flags: review?(pinkerton)
|
||
Comment 2•20 years ago
|
||
maybe i'm not seeing enough context, but it seems like removing this will cause the flow of the routine to change (since before it would always return). am i missing something?
Summary: remove CurrentPortIsWMPort() → remove CurrentPortIsWMPort()
|
||
Comment 3•20 years ago
|
||
Comment on attachment 172747 [details] [diff] [review] remove CurrentPortIsWMPort() Yeah, that's wrong. We also need to review all the callers of FrontWindow(), because this returns the menu bar window on Tiger.
Attachment #172747 -
Flags: superreview?(sfraser_bugs) → superreview-
|
|
||
Updated•20 years ago
|
Attachment #172747 -
Flags: review?(pinkerton) → review-
|
||
Comment 4•20 years ago
|
||
(In reply to comment #3) > (From update of attachment 172747 [details] [diff] [review] [edit]) > Yeah, that's wrong. > > We also need to review all the callers of FrontWindow(), because this returns > the menu bar window on Tiger. > Just guessing, but is this the cause of bug 292448 ?
|
|
||
Updated•16 years ago
|
Assignee: sfraser_bugs → joshmoz
|
Assignee | |
Updated•16 years ago
|
Product: Core → Core Graveyard
This was removed from the tree, -> FIXED.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•