280038 - Focusing out of <select> causes default attr to appear

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Stephen Pride]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050114
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050114

Using an attribute as a reference in a <select> statement causes the default
attribute value to be elected when focus goes out of element.  I'll attach a
testcase for more clarity.

Reproducible: Always

Comment 1

[Stephen Pride]

Attachment: Bug that shows problem.

Should open with two selection boxes, both marked with "No" as the default. 
Select "Yes" in the first selection box and then set focus outside the first
one (by tabbing or clicking elsewhere).  The first selection box goes back to
the defualt attribute value of "No".

Comment 2

[aaronr]

I debugged this last night.  This bug is related to how the node values are set
by nsXFormsSelectElement.  Most controls have gone to
nsXFormsUtils::GetNodeValue(mBoundNode) and
nsXFormsMDGEngine::SetNodeValue(mBoundNode) instead of doing it by hand.

Honestly, I don't know exactly what is going wrong, other than when the node
value is set now by ::WriteSelectedItems, it sets it just fine.  But then when
the value is about to be read back in nsXFormsSelectElement::Refresh(), the act
of ennumerating the child node list will cause the string that held the value in
the textnode to be freed and re-assigned to its original value.

When I change to use the new approach noted above, the problem is corrected.

I will post a patch today.

Comment 3

[aaronr]

Attachment: proposed fix

This patch fixes the problem using the methods I noted earlier in the bug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 172587 [details] [diff] [review]
proposed fix

Isn't this breaking support for multiple selected values?

Comment 5

[aaronr]

Actually, doesn't break the support...we currently don't work with muliselect
list boxes -> https://bugzilla.mozilla.org/show_bug.cgi?id=278207.  Do you want
me to hold off with this patch until that is fixed?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

rather fix Bug 278207, it will probably help with this one too.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

If I'm right, this was fixed in Bug 278207.
Closing.