280093 - Update "Add to Sidbar" HTML text and JS addsidebar() function

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[benc]

If you look in lxr, you see that "Add to sidebar", which appears on the home
page says:

 80     <li id="sidebar"><a href="javascript:addSidebar()">Add to Sidebar</a>
(Requires Mozilla or Netscape 6)</li>

We should mention Netscape 7 and Firefox, and at least update the reference to
Netscape 7.x.

Also, it might be nice to add some browser detection. When I use Camino, it
sends me to the mozilla link, thinking I can get an extension, from searching
the Camino-product, I don't think this exists.

Comment 1

[Dave Miller [:justdave]]

see also bug 280092 for bmo-specific stuff related to this issue.

Comment 2

[Anne (:annevk)]

Attachment: patch #1

This fixes the link. (It was a 301.) Removes some invalid markup (per HTML 4.01
Strict). And updates the line about which browser you need.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 172871 [details] [diff] [review]
patch #1

>-<script type="text/javascript" language="JavaScript">
>+<script type="text/javascript">

Why remove the language attributes on all the script tags?  Aren't they
necessary for backwards compatibility?


>-      document.location.href = "http://www.mozilla.org/binaries.html";
>+      document.location.href = "http://www.mozilla.org/releases/";

Since the panel works with Firefox, we should recommend that and point this to
http://www.mozilla.org/ rather than the releases/ subdirectory, which is
specific to the Mozilla application suite.


>-    <li id="sidebar"><a href="javascript:addSidebar()">Add to Sidebar</a> (Requires Mozilla or Netscape 6)</li>
>+    <li id="sidebar"><a href="javascript:addSidebar()">Add to Sidebar</a> (Requires a Mozilla based browser like Mozilla Firefox)</li>

Nits: 

Requires -> requires

Mozilla based -> Mozilla-based or Mozilla

Comment 4

[Anne (:annevk)]

Myk, that does not break backcompat. See also bug 280410.

Comment 5

[Anne (:annevk)]

Attachment: patch #2

I would love to remove the useless <div class="intro"></div> and <div
class="outro"></div> as well by the way.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 174362 [details] [diff] [review]
patch #2

r=myk

The Harisovs will be removing the intro and outro tags, I think, per bug
278125, comment 16.

Comment 7

[Anne (:annevk)]

Attachment: patch #2 - patched from different dir

Comment 8

[Shane H. W. Travis]

Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  
index.html.tmpl
new revision: 1.19; previous revision: 1.18
done