280136 - Remove GetFinalState()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The methods nsIAccessible::GetFinalRole(), GetFinalState() and GetFinalValue()
were added to make the DHTML accessibily patch in bug 249998 small and reviewable.

Changing the code to remove the need for methods is going to be a large patch,
but it should be done. It's ugly to have GetRole and GetFinalRole, etc.

Comment 1

[Aaron Leventhal]

I think we might want to have some methods with names like GetStateInternal(), which are virtual but not interface methods. That's where the non-ARIA work would be done. But, it would mean there are still 2 methods for role, 2 methods for state, etc. However, I don't want a situation where every new impl class for a11y needs to remember to call methods for ARIA work.

Let's safe this for after Firefox 3.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: inspector-patch

Comment 3

[alexander :surkov (:asurkov)]

Attachment: mozilla-patch

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 345842 [details] [diff] [review]
inspector-patch

sorry, it was excess mouse click

Comment 5

[[e-mail]]

Will you need to change the minVersion in DOMi's install.rdf?

Comment 6

[Shawn Wilsher :sdwilsh]

For the inspector patch, we'll still need to be able to support 3.0, so can you have this degrade gracefully?

Comment 7

[alexander :surkov (:asurkov)]

Attachment: inspector-patch2

Does it work for you?

Comment 8

[Aaron Leventhal]

Comment on attachment 345843 [details] [diff] [review]
mozilla-patch

David, how would you like a nice code reorg review? :)

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Sure. Can it wait until tonight?

(In reply to comment #8)
> (From update of attachment 345843 [details] [diff] [review])
> David, how would you like a nice code reorg review? :)

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 345843 [details] [diff] [review]
mozilla-patch

You have my r+ :)

Aaron owes me a doughnut.

Wow that was tedious, but this makes the code much nicer. Surkov, nice catch fixing the mochitests too. I'm loving the NS_IMETHOD to "virtual nsresult", and NS_IMETHODIMP to "nsresult" changes. Starting to look like C++ again :)

Comment 11

[Shawn Wilsher :sdwilsh]

Comment on attachment 345915 [details] [diff] [review]
inspector-patch2

r=sdwilsh

Comment 12

[alexander :surkov (:asurkov)]

inspector's changeset: http://hg.mozilla.org/dom-inspector/rev/f70f22b6a96e
mozilla's changeset: http://hg.mozilla.org/mozilla-central/rev/ed2e583d9edf