Run junk mail controls on Folder doesn't work

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Susanne Jaeger, Assigned: Scott MacGregor)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050128 Mnenhy/0.7.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050128 Mnenhy/0.7.1

With Mnenhy the junk mail status unknown is indicated by a red question mark.
Automatic Junk Mail Controls often fail to work reliable on mail that are moved
to a subfolder by filters (Mailinglists). Usually it was possible to "run junk
mail controls on Folder" manually and change status of 99+% of those mails to
junk or not junk. This doesn't work any more.

Reproducible: Always

Steps to Reproduce:
1. Take a folder with a relevant part of Mail with junk status unkown.
Alternatively take a folder with mostly not Junk Mail and delete the
corresponding .msf-File
2. Choose "Run Junk Mail Controls on Folder" from Folder
3.

Actual Results:  
no change of the Junk Status of any mail. Collapsed threads expand and that's it.

Expected Results:  
All or nearly all Mails should be marked as either not junk or junk.

According a discussion in a german newsgroup the bug arose somewhere between 
2005011302 and 2005011404.

Comment 1

13 years ago
I can confirm this behaviour for: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050128
Mnenhy/0.7.1 and some earlier Builds. 

Suggest to change the OS to all. 

Updated

13 years ago
Keywords: regression

Comment 2

13 years ago
Possible checkin that caused this bug: Bug 245499
Bonsai link:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-13+01%3A00%3A00+&maxdate=2005-01-14+05%3A00%3A00&cvsroot=%2Fcvsroot

Comment 3

13 years ago
Eyal: I think your patch from Bug 245499 caused this bug here (only checkin in
that timeframe to junk mail filtering/controls), can you look into this?

Comment 4

13 years ago
You're right, Frank. I removed the startBatch() calls from the C++ code but
forgot to remove them from the js code as well. 

From mail/base/content/mailCommands.js
the following lines should be removed:

672   getJunkmailComponent();
673   var counter = 0;
674   gJunkmailComponent.startBatch();

And from mailnews/base/resources/content/mailCommands.js
the lines

678   getJunkmailComponent();
679   gJunkmailComponent.startBatch();

and this should be sufficient. I'll try testing this myself later, but I'm
terribly pressed for time these days.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

13 years ago
This is funny, I'm trying to attach a patch and bugzilla is telling me 'you
didn't specify a file'. Weird.

Comment 6

13 years ago
Created attachment 172803 [details] [diff] [review]
seamonkey patch v1

Comment 7

13 years ago
Just curious, but shouldn't junk mail controls work before filters get applied?
Wouldn't this be a more elegant and simpler solution?
re-assign to mscott (or david?)

scott, I see the same problem with the tbird trunk builds for win32 (with the
inline spell checker)
Assignee: sspitzer → mscott
OS: Linux → All
Hardware: PC → All

Comment 9

13 years ago
(In reply to comment #8)
> scott, I see the same problem with the tbird trunk builds for win32

Of course you do. The same removal needs to be done there too. But first let me
get a review for this patch.

Updated

13 years ago
Attachment #172803 - Flags: review+

Comment 10

13 years ago
Comment on attachment 172803 [details] [diff] [review]
seamonkey patch v1

And someone please check this in when the SR is granted.
Attachment #172803 - Flags: superreview?(mscott)
(Assignee)

Comment 11

13 years ago
Comment on attachment 172803 [details] [diff] [review]
seamonkey patch v1

I'll check this in. Can you make me a thunderbird one please? thanks.
Attachment #172803 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 12

13 years ago
fixed for seamonkey. leaving open for the thunderbird patch.
Status: NEW → ASSIGNED

Comment 13

13 years ago
Sorry Eyal and Scott, but this is not fixed for seamonkey now. 

Start "Run Junk Mail Controls on Folder" still do nothing with:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050131
Mnenhy/0.7.0.10002 {Build ID: 2005013118}

No activity in Statusbar, and the Junk-Status wasn't changed in marked Folder.

Comment 14

13 years ago
(In reply to comment #13)

Could you make sure that the patch is already incorporated in the build you are
using? Could you provide a Javascript console log?

Updated

13 years ago
Version: unspecified → Trunk
Formerly i had applied the patch
https://bugzilla.mozilla.org/attachment.cgi?id=172803 to my source with no
effect. My current cvs-fetch contains this patch, just made sure.

The bug is still there.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050201

Comment 16

13 years ago
(In reply to comment #14)
> (In reply to comment #13)
> 
> Could you make sure that the patch is already incorporated in the build you are
> using? Could you provide a Javascript console log?
> 

Sure:

Error: gJunkmailComponent has no properties
Source File: chrome://messenger/content/mailCommands.js
Line: 650

    gJunkmailComponent.classifyMessage(messageURI, msgWindow, listener);

Using Tinderbox/Creature 2005013123 this Moment. 

Comment 17

13 years ago
Ok, so it seems I shouldn't have deleted the gJunkMailComponent assignment. And
David gave me the review+ so easily... anyway, the getJunkmailComponent();
before  gJunkmailComponent.startBatch(); should be re-inserted. I can make this
patch when I get home later today, although I've been having trouble pulling the
source lately. Or someone else could do it. Sorry for the mess, I'm just in a
middle of a  million things right now.
(Assignee)

Comment 18

13 years ago
i just checked in a fix for the JS error in the suite. 

Comment 19

13 years ago
Created attachment 173349 [details] [diff] [review]
tbird patch v1

this time no removing the getJunkmailComponent()...
Attachment #173349 - Flags: superreview?(mscott)
Attachment #173349 - Flags: review?(bienvenu)

Updated

13 years ago
Attachment #173349 - Flags: review?(bienvenu) → review+
(Assignee)

Updated

13 years ago
Attachment #173349 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 20

13 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 21

13 years ago
Just Friday (3/11/05) I got some junk mails which stayed in the inbox, but they
were properly marked as junk. 

version 1.0+ (20050309-pigfoot)
Also did it in the "official" 1.0.1 build.



Please reopen this bug.

Comment 22

13 years ago
Just crashed again trying to edit a filter which doesn't work.
You need to log in before you can comment on or make changes to this bug.