280284 - No `View Selection Source' on context menu if non-text selected

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Joe Llywelyn Griffith Blakesley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050125 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050125 Firefox/1.0+

(I'm not sure whether this should be under the `View Source' component.)

Reproducible: Always

Steps to Reproduce:
1. Select part of a page not containing text (just objects like images)
2. Click on the page with your pointing devices secondary button

Actual Results:  
`View Selection Source' item does not appear.

Expected Results:  
`View Selection Source' item should be available.

Comment 1

[Frank Wein [:mcsmurf]]

Confirming, Seamonkey version of this Bug is Bug 170893

Comment 2

[Jason Barnabe (np)]

Attachment: patch

This implements nsContextMenu.isContentSelected. I've switched all the context
menu items that looked at isTextSelected (including View Partial Source) to
look at isContentSelected, with the exception of "Search Web for...".

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 180259 [details] [diff] [review]
patch

Using __proto__ here fails on trunk, I know there's been some recent changes,
those may have bitrotted this, but it works without it in my local build.  The
indentation should be *shudder* 4-space, to match prevailing style here.

other than that, this is good to go.

Comment 4

[Jason Barnabe (np)]

Attachment: patch v2 [Checked in: Comment 7]

Fixed getSelection call and indenting.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 185637 [details] [diff] [review]
patch v2
[Checked in: Comment 7]

sweet.	Sorry these have been slow, hopefully the whacking of the review queue
will continue long into the night.

Comment 6

[timeless]

Comment on attachment 185637 [details] [diff] [review]
patch v2
[Checked in: Comment 7]

you need to ask for approval before someone can check something in atm.

Comment 7

[Daniel Brooks [:db48x]]

fix checked in

Comment 8

[PikeUK]

I think this may have caused the minor regression in Bug 303898 (I could be
wrong though).