280293 - Don't use nsIDOMNode:GetNextSibling() -- it is an O(n) operation

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

nsAccessibleTreeWalker actually does extra work to use
nsIDOMNode::GetNextSibling() instead of using something that indexes a child
from the parent.

It turns out this makes Gecko do a lot more work. GetNextSibling() has to use
IndexInParent() to do its work.

Comment 1

[Aaron Leventhal]

Attachment: Use nsIContent::GetChildAt() except at top of doc, where we'll now use GetChildNodes() which is similar to the nsIDOMNodeList walking we already do for anon content

Comment 2

[Boris Zbarsky [:bzbarsky]]

It'll take me some time to get to this; I'm pretty swamped with reviews...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172785 [details] [diff] [review]
Use nsIContent::GetChildAt() except at top of doc, where we'll now use GetChildNodes() which is similar to the nsIDOMNodeList walking we already do for anon content

sr=bzbarsky

Comment 4

[Aaron Leventhal]

Comment on attachment 172785 [details] [diff] [review]
Use nsIContent::GetChildAt() except at top of doc, where we'll now use GetChildNodes() which is similar to the nsIDOMNodeList walking we already do for anon content

verbal r= timeless

Comment 5

[Aaron Leventhal]

Checking in accessible/src/base/nsAccessibleTreeWalker.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibleTreeWalker.h,v  <-- 
nsAccessibleTreeWalker.h
new revision: 1.7; previous revision: 1.6
done
Checking in accessible/src/base/nsAccessibleTreeWalker.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibleTreeWalker.cpp,v  <-- 
nsAccessibleTreeWalker.cpp
new revision: 1.11; previous revision: 1.10
done