280415 - "Save As Page..." menu item disappears if no window open

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[David Lawhon]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050129
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050129

When all windows are closed, the current Mozilla daily build for Mac does not
show the "Save As Page..." menu item in the File menu. (It should show it
greyed-out.) However, it does show the command's keyboard equivalent.

Reproducible: Always

Steps to Reproduce:
1. Launch Mozilla for Mac daily build.
2. Close the open window.
3. Pull down the file menu and look for the "Save Page As..." item.

Actual Results:  
The "Save Page As..." item does not appear. But, the keyboard-equivalent
(command-S) is there, on an empty line.

Expected Results:  
The menu should show "Save Page As..." as greyed-out, with the greyed-out
keyboard equivalent next to it.

This occurs under Mac OS X 10.3.7 on a PowerMac G5/2.5GHz dual with 2GB RAM.

Comment 1

[David Lawhon]

Attachment: "Save Page As..." missing when no windows are open

Comment 2

[Hiro]

Confirm.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050129

Comment 3

[Boris Zbarsky [:bzbarsky]]

David, is this a recent regression?  If so, can you maybe narrow down when this
broke using the builds on ftp://ftp.mozilla.org and http://archive.mozilla.org ?

Comment 4

[David Lawhon]

Boris, the bug first appeared in the 2004-12-26-06-trunk Mac build.
The last Mac trunk build before that was 2004-12-21-06-trunk.

-- David

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checkins in that range:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-12-21+04%3A00%3A00&maxdate=2004-12-26+08%3A00%3A00&cvsroot=%2Fcvsroot

None of those look like they should affect this... the closest is bug 7840

Comment 6

[Ian Neal]

Do any error messages appear in the JS console relating to this?

Comment 7

[jhp (no longer active)]

Mano, you've fixed problems like this in the past, right?

Comment 8

[Ian Neal]

From jhpedemonte on irc:
IanN: JavaScript error: chrome://navigator/content/navigator.js, line 1315:
browser has no properties
IanN: it's in 'function updateCloseItems()', on the line 'if
(browser.getStripVisibility()) {'

changing the line:
if (browser.getStripVisibility()) {
to:
if (browser && browser.getStripVisibility()) {
might fix the problem - can anyone test?

Comment 9

[Stefan [:stefanh]]

(In reply to comment #8)
> From jhpedemonte on irc:
> IanN: JavaScript error: chrome://navigator/content/navigator.js, line 1315:
> browser has no properties
> IanN: it's in 'function updateCloseItems()', on the line 'if
> (browser.getStripVisibility()) {'
> 
> changing the line:
> if (browser.getStripVisibility()) {
> to:
> if (browser && browser.getStripVisibility()) {
> might fix the problem - can anyone test?

Changing the line to "if (browser && browser.getStripVisibility()) {" brings the
 menu item back. However, it is not grayed out. And i get a js error trying to
use the menuitem while no windows are open:

Error: saveDocument is not defined
Source File: chrome://global/content/hiddenWindow.xul
Line: 1

Comment 10

[[e-mail]]

(In reply to comment #9)
>Changing the line to "if (browser && browser.getStripVisibility()) {"
>brings the menu item back. However, it is not grayed out.
That's probably because Browser:SavePage isn't listed in hiddenWindowStartup()

Comment 11

[Stefan [:stefanh]]

(In reply to comment #10)
> (In reply to comment #9)
> >Changing the line to "if (browser && browser.getStripVisibility()) {"
> >brings the menu item back. However, it is not grayed out.
> That's probably because Browser:SavePage isn't listed in hiddenWindowStartup()

yep, just noticed that. It works with 'Browser:SavePage' listed in
hiddenWindowStartup().

Comment 12

[Ian Neal]

Attachment: mac save page as fix patch v0.1 (Checked in)

Adds Neil/stefan's suggestion to mine.

Comment 13

[Asa Dotzler [:asa]]

not going to block the beta1 on this bug but we'd certainly consider a patch for
approval if it happens in time. If not, then this would be a good one to get for b2.

Comment 14

[Ian Neal]

Comment on attachment 174142 [details] [diff] [review]
mac save page as fix patch v0.1 (Checked in)

requesting a= for simple bug fix

Comment 15

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 174142 [details] [diff] [review]
mac save page as fix patch v0.1 (Checked in)

a=caillon for 1,8beta

Comment 16

[Ian Neal]

Comment on attachment 174142 [details] [diff] [review]
mac save page as fix patch v0.1 (Checked in)

Checking in navigator.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v	<-- 
navigator.js
new revision: 1.563; previous revision: 1.562
done

Comment 17

[Stefan [:stefanh]]

--> Fixed