280418 - ctrl+shift F4 should close other tabs

Status: NEW

(Firefox :: Tabbed Browser, enhancement, P5)

Description

[Richard Klein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050106 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050106 Firefox/1.0+

Ctrl+F4 closes the current tab.  Ctrl+Shift+F4 should close all other tabs. 
This will match keybinding in eclipse.

Reproducible: Always

Comment 1

[Richard Klein]

Attachment: version 1.0

This patch Adds ctrl+shift+f4 key handler to tabbrowser.xml.  
Requesting review as well.

Comment 2

[Nickolay_Ponomarev]

confirming

Comment 3

[Richard Klein]

Comment on attachment 173404 [details] [diff] [review]
version 1.0

This patch has bitrotted.  I'll attach a new one.

Comment 4

[Richard Klein]

Attachment: Updated Patch

Comment 5

[Richard Klein]

any suggestion on who would be best to review this?

Comment 6

[Nickolay_Ponomarev]

Don't know, but most of reviews I've seen in Firefox were done by mconnor.

btw, perhaps it would make sense to use nested if's here?

Comment 7

[Richard Klein]

Attachment: Nest if

Okay this patch uses a nested if instead.

Comment 8

[Richard Klein]

Comment on attachment 180289 [details] [diff] [review]
Updated Patch

obsolete the previous patch

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 180293 [details] [diff] [review]
Nest if

this should be safe for branch, and easily testable

Comment 10

[Richard Klein]

I don't have CVS access.  Mike, could you check this in?

Comment 11

[Richard Klein]

Comment on attachment 180293 [details] [diff] [review]
Nest if

It looks like this path has bitrotted.

Comment 12

[Richard Klein]

Attachment: Unbitrotted pach

Mike this is an unbitrotted version of last patch.  Could you review it again?

Comment 13

[Richard Klein]

Comment on attachment 197849 [details] [diff] [review]
Unbitrotted pach

Patch has bitrotted again

Comment 14

[Richard Klein]

Attachment: New unbitrotted path

Requesting review from mano since he touched the file last.

Comment 15

[Richard Klein]

Comment on attachment 243833 [details] [diff] [review]
New unbitrotted path

sorry that one has an extra ) in it

Comment 16

[Richard Klein]

Attachment: correct unbitrotted patch

Sorry for all the bug spam.  This should be the correct patch.

Comment 17

[Aaron Leventhal]

Ctrl+W also closes the current tab, and is easier to type.

How about ctrl+shift+w as well?

Comment 18

[Asaf Romano (gone)]

Comment on attachment 243834 [details] [diff] [review]
correct unbitrotted patch

aaron: ctrl+shit+w is used for close-window.

Needs ui-r from beltzner/mconnor. FWIW, I'm not sure I like this. This is not a standard keyboard shortcut, nor there's a place in which it could be exposed (other than help).

Comment 19

[Richard Klein]

Comment on attachment 243834 [details] [diff] [review]
correct unbitrotted patch

Mike can you review this again?  It did not get checked in before the patch bitrotted.  Alaf is asking for a UI review before it gets checked in.

Comment 20

[Asaf Romano (gone)]

Alaf? woot!

Comment 21

[Richard Klein]

Asaf :)

Comment 22

[Richard Klein]

Comment on attachment 243834 [details] [diff] [review]
correct unbitrotted patch

Removed the review request on an old patch.

Comment 23

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 24

[Emil Ivanov]

(In reply to comment #17)
> Ctrl+W also closes the current tab, and is easier to type.
> 
> How about ctrl+shift+w as well?

I think ctrl+shift+f4 should close other firefox windows if this worth at all (likely not), but the current bug should use ctrl+shift+w to close other tabs, because ctrl+f4 closes window and not tab, and ctrl+w closes current tab.