280439 - Revise pref-download page and give back default beep for download complete

Status: RESOLVED DUPLICATE of bug 490467

(SeaMonkey :: Download & File Handling, defect)

Description

[Ian Neal]

Since the landing of my patch on bug 7840 there is no way of easily having the
default beep for when a download completes. The hard way of having it is to
either delete the file currently being used or to navigate to the default beep file.

Several possible ways of fixing this:
a) Try and squash more onto existing Downloads page.
b) Create a new Notifications page for Navigator and make it identical in layout
to the Mail & News Notifications page.
c) Write enable text field so when blank default beep is played - similar to
sound notification for popup windows.

Comment 1

[Ian Neal]

Actually it wasn't my bug that created the read only text box, that was bug
260818 - adding the author for a view ;-)
Neil brought up this issue in bug 266195 so adding him too.

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #1)
> Actually it wasn't my bug that created the read only text box, that was bug
> 260818 - adding the author for a view ;-)
> Neil brought up this issue in bug 266195 so adding him too.

Actually, it was bug 16498 - still my fault though.

Ian, you can reassign this to me if you don't want to take care of it.  

Comment 3

[Ian Neal]

Just a reminder to me - if I've not done something on this by 1.9, Chris said
he'd do it :-)

Comment 4

[Ian Neal]

Attachment: Work in progress v0.1

This patch:
* re-enables beep for empty sound strings
* makes the sound string look prettier
* saves the sound string if it needed to be fixed up

Not sure if this is the correct way to do any of the above yet.

Comment 5

[Ian Neal]

Attachment: Possible redesign of pref-download page

Original layout suggested by Chris - wording changes by me - any comments?

Comment 6

[[e-mail]]

Sorry, I don't see how you clear the current sound file.

Comment 7

[Ian Neal]

Attachment: Revised design with writable sound textbox

Okay I forget to make the textbox writable in the previous image

Comment 8

[Ian Neal]

Attachment: Revised pref patch v0.1a

Changes from v0.1:
* Added checking for Shutdown() function from within nsPrefWindow.js
* Made sound_url textbox writable
* Used Shutdown function to fixup any file location entered in sound_url
textbox
* Reorganised page as suggested by Chris
* Reworded some of the labels to make them fit better in new design

Comment 9

[Ian Neal]

Old summary was "Default beep for download complete"

Comment 10

[timeless]

Comment on attachment 173033 [details] [diff] [review]
Revised pref patch v0.1a

i'd really like the two variables finish/download to be named such that i could
understand that one is the pretty one.

also, i believe it's "Download Manager" :)

Comment 11

[Ian Neal]

Attachment: Revised pref patch with new names v0.1b

Carrying forward r=

Comment 12

[[e-mail]]

I have a sneaky suspicion that some of this patch is to work around our broken
dialog onchange story. If so, please can you remove it? Thanks.

Comment 13

[Ian Neal]

There is some wierdness with how onchange fires. Unless you are debugging the JS
onchange event happens after the PageData has been saved via switchPage thus the
changes are not saved.
Is there anyway to make sure the onchange event has been processed before the
PageDate is saved?

Comment 14

[Ian Neal]

If you look at pref-proxies use of onchange that is also broken for switching
between pref pages.
Select Automatic Proxy Configuration URL
Enter something like c:\proxy.pac and then click onto another pref page
If you are quick you can see the URL being changed to file:///c:/proxy.pac but
when you click back to the proxies pref page it is still c:\proxy.pac and
clicking OK stores it as c:\proxy.pac instead of as a URL.

Comment 15

[Serge Gautherie (:sgautherie)]

Ian, Neil,
Are you still working on this ?

Comment 16

[Ian Neal]

This will probably be closed off once this panel is moved to the new pref window

Comment 17

[Robert Kaiser]

Comment on attachment 175076 [details] [diff] [review]
Revised pref patch with new names v0.1b

obsolete patch, none of those files exists any more in that form.

Comment 18

[Robert Kaiser]

Reintroducing sound is now bug 490467, I think we can safely dupe this there.