280561 - Throbber in tab does not always work when using non-default theme

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Anton van Bohemen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050128 Firefox/1.0+ (BlueFyre)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050128 Firefox/1.0+

I use firefox with the Qute theme. When multiple tabs are open, and I follow a
link in the same page (which also remains in the same tab) the throbber in the
tab does not work while the page is loading. The throbber in the toolbar works
fine though. 

Reproducible: Always

Steps to Reproduce:
1. Use a non default theme
2. Have at least two tabs open, so the tabbar shows up
3. Follow a link in which you stay in the same tab
4. Or: press back or forward in the same tab
5. Or: drag a link from a page in one tab to another tab

Actual Results:  
The throbber in the tab in which the page is loading does not spin

Expected Results:  
Obvious

This bug does *not* show up:
1. When using the default theme
2. When selecting a bookmark to load in a new tab
3. When selectin a link to load in a new tab

I tried both the Qute 3.0 theme and Noia Extreme 2.81, both are the latest
versions at update.mozilla.org. I don't think it's theme manager related so I
filed it under Tabbed Browser.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

The Gray Modern theme also loses the 'throbber' in the current nightly builds.
Interestingly enough, however, is that using the new Extention TabMix with this 
theme shows the 'throbber' activity on tabs again.  

Comment 2

[Anton van Bohemen]

It regressed before 2005-01-17 at least, that is the oldest build I still had.
But I started using other themes only after 01-12, that's when the theme
installer was fixed. I don't know if it was already broken in that build though.

Even worse: with a new profile and no extensions, the throbber in the tab is
never working, even in the cases I described that worked before (except for the
default theme, which is still fine).

Comment 3

[Peter van der Woude [:Peter6]]

->NEW

Comment 4

[Jim Britt]

I'll using the Default theme and the throbber Doesn't work on the tabs on a W2K
w/SP4.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050203 Firefox/1.0+

Comment 5

[Stuart]

This is an invalid bug as the throbber within the task has moved due to
developement, so the styling needs to be changes, not the code

Comment 6

[Jim Britt]

(In reply to comment #4)
> I'll using the Default theme and the throbber Doesn't work on the tabs on a W2K
> w/SP4.
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050203
Firefox/1.0+

Sorry, the problem was with the "Tab X" extension I was using. I disabled it and
now the throbber works.

Comment 7

[PikeUK]

As Stuart said, code changes sometimes break third-party themes, that's not a bug.

-> INVALID

Comment 8

[Anton van Bohemen]

Excuse me?? If code changes require themes to be changed, the theme version
should be bumped and the changes need to be documente iirc, so theme developers
can create correct themes. Without this, there will be no working themes
whatsoever for firefox 1.1.

The theme version should be bumped anyway for themes to adapt to the new options
panel anyway, but that's another problem.

Comment 9

[PikeUK]

(In reply to comment #8)
> Excuse me?? If code changes require themes to be changed, the theme version
> should be bumped and the changes need to be documente iirc, so theme developers
> can create correct themes. Without this, there will be no working themes
> whatsoever for firefox 1.1.
> 
> The theme version should be bumped anyway for themes to adapt to the new options
> panel anyway, but that's another problem.

Firefox doesn't use skinVersion anymore so there is nothing to bump, themes are
versioned via install.rdf instead. As for documentation, that's what threads
such as the following are for:

http://forums.mozillazine.org/viewtopic.php?t=197434

In fact the issue that caused this bug is listed right there in the first post.