Remove text from image alt attributes in Help



Firefox Graveyard
Help Documentation
13 years ago
2 years ago


(Reporter: Jeff Walden (gone starting June 8), Assigned: zmanji)




(1 attachment)

8.24 KB, patch
Steffen Wilberg
: review+
Details | Diff | Splinter Review


13 years ago
When the user isn't connected to the Internet, images don't load.  They're
replaced by the contents of the alt attribute, which will always be present
because it's required in strict XHTML.  Unfortunately, the alt text isn't very
helpful right now.

There are a couple solutions.  We could leave the alt text as is, but the alt
text is useless, so Help becomes no better.  We could fix alt text to describe
the screenshot, but I don't think we can do it better than the text accompanying
the screenshots already does (or so I think -- people who actually can't use the
screenshots are more than welcome to comment).  I think the best bet is to
change the alt text for our screenshots to "" (or " ", or whichever's more
kosher).  Then it won't unduly interrupt the text when the user's not connected
to the Internet, and it won't be a completely useless bit of text for users who
can't use the images themselves.

Any thoughts on this before the 1.8 branch starts?  I want to get this in before
1.1 (barring any clueful suggestions to the contrary), so this needs to be done
before branch point.

Comment 1

13 years ago
I think that the alt text should be replaced with " ", because alt text could
confuse the user and it isn't very useful. How ever if we switched to XML (I
think) we wouldn't have this problem.

In any case I think something should be done. Hopefully before the branch.

Comment 2

13 years ago
Yeah, let's use alt="" everywhere. We're already using it in a couple of places.
There's no use in e.g. customization.xhtml displaying the string "Theme Manager"
when you're offline and the image is not in the chache.

Comment 3

13 years ago
Created attachment 178009 [details] [diff] [review]
patch v1

a patch. review and checkin if good
Attachment #178009 - Flags: review?(steffen.wilberg)

Comment 4

13 years ago
Comment on attachment 178009 [details] [diff] [review]
patch v1

I'm taking care of prefs.xhtml in bug 279506 however.
Attachment #178009 - Flags: review?(steffen.wilberg) → review+

Comment 5

13 years ago
Depends on bug 279506 for the prefs.xhtml part.

Checking in the rest:
Checking in mozilla/browser/components/help/locale/en-US/customization.xhtml;
/cvsroot/mozilla/browser/components/help/locale/en-US/customization.xhtml,v  <--
new revision: 1.16; previous revision: 1.15
Checking in mozilla/browser/components/help/locale/en-US/download_manager.xhtml;
<--  download_manager.xhtml
new revision: 1.15; previous revision: 1.14
Checking in mozilla/browser/components/help/locale/en-US/using_firebird.xhtml;
<--  using_firebird.xhtml
new revision: 1.20; previous revision: 1.19
Assignee: jwalden+fxhelp → zmanji
Depends on: 279506


13 years ago

Comment 6

13 years ago
prefs.xhtml part fixed by bug 279506.
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.