280590 - Pinstripe: Browser tabs should be focusable (when full keyboard access is on)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Asaf Romano (gone)]

Not as the window/*nix version, pinstripe tabs are not focusbale. We can't [yet]
fix native tabs (issues with mac focus rings...), but browser tabs are easy to fix.

Comment 1

[Asaf Romano (gone)]

Attachment: v1

Kevin, any comments? (note: starting from latest builds, you should either turn
on fka or set the tabfocus pref in order to get the tabbar focusable)

Comment 2

[Asaf Romano (gone)]

Assigning this to Kevin. The attached style rules might be good enough, but i'm
not the theme owner.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 173023 [details] [diff] [review]
v1

We can tweak looks after, but we want to enable this to get some testing going.

This also enables the patch from bug 179656 to work with the keyboard, which is
a nice power-user touch.

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 173023 [details] [diff] [review]
v1

a=shaver.

Comment 5

[Asaf Romano (gone)]

Checking in toolkit/themes/pinstripe/global/browser.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/browser.css,v  <--  browser.css
new revision: 1.4; previous revision: 1.3
done

Comment 6

[philippe (part-time)]

There is a small error in that patch: padding can't be negative 

> padding-top:-1px !important



Or do you want a bug filed for this ?

(btw, you better of using the outline property instead of border property, you
then could use outline-offset)

Comment 7

[Asaf Romano (gone)]

fixed that typo.

Comment 8

[José Jeria]

See bug 296615, its about tabs being focused. Is this the intentional behavior?

Comment 9

[sairuh (rarely reading bugmail)]

interestingly, I can still focus browser tabs (via Tab key) even when full
keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
(and, of course, it also works when full keybd access is on.)

is this expected?

Comment 10

[Asaf Romano (gone)]

(In reply to comment #9)
> interestingly, I can still focus browser tabs (via Tab key) even when full
> keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
> (and, of course, it also works when full keybd access is on.)
> 
> is this expected?

Well, not really expected, I think (actually, not being able to focus them
partly erases the MoveTabs feature).

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bit late but verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090918 Shiretoko/3.5.4pre ID:20090918030730