Closed Bug 280590 Opened 15 years ago Closed 15 years ago

Pinstripe: Browser tabs should be focusable (when full keyboard access is on)

Categories

(Firefox :: Tabbed Browser, defect)

All
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox1.5

People

(Reporter: mano, Assigned: mano)

References

Details

(Keywords: access)

Attachments

(1 file)

Not as the window/*nix version, pinstripe tabs are not focusbale. We can't [yet]
fix native tabs (issues with mac focus rings...), but browser tabs are easy to fix.
Attached patch v1Splinter Review
Kevin, any comments? (note: starting from latest builds, you should either turn
on fka or set the tabfocus pref in order to get the tabbar focusable)
OS: All → MacOS X
QA Contact: tabbed-browser → bugzilla
Assigning this to Kevin. The attached style rules might be good enough, but i'm
not the theme owner.
Assignee: bugs → kevin
Comment on attachment 173023 [details] [diff] [review]
v1

We can tweak looks after, but we want to enable this to get some testing going.

This also enables the patch from bug 179656 to work with the keyboard, which is
a nice power-user touch.
Attachment #173023 - Flags: review+
Attachment #173023 - Flags: approval-aviary1.1a1? → approval-aviary1.1a2?
Comment on attachment 173023 [details] [diff] [review]
v1

a=shaver.
Attachment #173023 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Assignee: kevin → bugs.mano
Checking in toolkit/themes/pinstripe/global/browser.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/browser.css,v  <--  browser.css
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
There is a small error in that patch: padding can't be negative 

> padding-top:-1px !important



Or do you want a bug filed for this ?

(btw, you better of using the outline property instead of border property, you
then could use outline-offset)
See bug 296615, its about tabs being focused. Is this the intentional behavior?
interestingly, I can still focus browser tabs (via Tab key) even when full
keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
(and, of course, it also works when full keybd access is on.)

is this expected?
(In reply to comment #9)
> interestingly, I can still focus browser tabs (via Tab key) even when full
> keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
> (and, of course, it also works when full keybd access is on.)
> 
> is this expected?

Well, not really expected, I think (actually, not being able to focus them
partly erases the MoveTabs feature).
Bit late but verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090918 Shiretoko/3.5.4pre ID:20090918030730
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → tabbed.browser
Hardware: PowerPC → All
You need to log in before you can comment on or make changes to this bug.