280594 - Codesighs uses wrong 'find' and 'sort' on windows

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Not sure which versions of windows, or cygwin, has this problem. In some cases
just executing 'find' and 'sort' will not use the cygwin programs, but rather
the ones that comes with windows. Which of course are compleatly incompatible
making codesighs break horribly. The solution is to give a compleat path to the
programs.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: use absolute paths

I hope it's ok to assume that these utilities are installed in /usr/bin in a
cygwin install? Note that changing the PATH doesn't help for whatever reason.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do you need to change basesummary.win.bash too?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

probably so, i've never used it...

I found one more place that uses sort as well. Strangly enough i'm not getting
an error, but I do get strange results. I'll do some more testing and i'll
attach a new patch once things seem to be working

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: better patch

This one fixes the last sort as well as basesummary.win.bash

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in