280610 - Kids of fieldset should have it as style context parent

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See comments in bug 240571.  Basically, the kids of a fieldset should have the
fieldset as the style context parent, not the anonymous area frame the fieldset
creates.

We'd probably need to fix our style context tree verification code if we do this.

Attaching a testcase; it shows the same issue with table cells and columnated
blocks (interestingly, we manage to get this right for scrollable blocks).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 323656.

Comment 3

[Jeff Walden [:Waldo]]

Is the testcase here redundant with the ones committed there?  I think it is, but I'm not sure exactly which inheritance edge cases need to be tested, and at a cursory glance they differ between this testcase and the fieldset ones in the patch.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, the committed testcases cover this bug.

Comment 5

[Martijn Wargers (dead)]

Verified fixed on trunk and branches.
I'm now seeing the border around the various texts in the testcase.