280639 - When creating bookmarkable template, it is called "this link"

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Stephen Lee]

Steps to reproduce:
1) Load enter_bug.cgi and select a product.
2) Set some fields ready to create a template
3) Click [Remember values as a bookmarkable template]
4) Add the resulting link to your bookmarks, using the default name.

Actual results:
Bookmarked link is called "this link". Unless you remember how it got there or 
examine the URL, the name offers no clue about what it is a link to.

Expected results:
Linkified text should be something more descriptive. e.g. "Enter Bug from 
Template".

Comment 1

[Dave Miller [:justdave]]

hmmm...  if the browser is javascript-enabled, we could prompt them with a
javascript dialog to ask for a name to give the bookmark, then alter the link
accordingly before telling them to bookmark the link.

Comment 2

[Stephen Lee]

(In reply to comment #1)
> hmmm...  if the browser is javascript-enabled, we could prompt them with a
> javascript dialog to ask for a name to give the bookmark, then alter the link
> accordingly before telling them to bookmark the link.

Javascript prompts sounds a bit OTT to me - the browser will provide funtions 
for naming / renaming a bookmarked link. I was merely suggesting reworking the 
text / linkification so that the default is a bit more sane, just as one would 
normally prefer:

Follow this link to see a _picture_of_justdave_
to:
Follow _this_link_ to see a picture of justdave

(or perhaps you'd prefer neither depending on how camera-shy you are!)

Comment 3

[Stephen Lee]

Suggested pseudo-patch to template/en/default/bug/create/make-template.html.tmpl

 <p>
-If you bookmark <a href="enter_bug.cgi?[% url FILTER html %]">this link</a>,
-going to the bookmark will bring up the enter [% terms.bug %] page with the 
fields
+You can bookmark the following link:
+<a href="enter_bug.cgi?[% url FILTER html %]">[% terms.Bug %] Template</a>
+<br>
+This bookmark will bring up the enter [% terms.bug %] page with the fields
 initialized as you've requested.
 </p>


Even though this is still static text, "Bug Template" will remind a user that 
the saved link came from bugzilla, rather than some other random site.


Personally, I would think anything going much further than this might as well 
finish the job by allowing the named bookmark to be stored in the page footer 
alongside the named queries, but that would be a different bug/RFE.

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Stephen's suggestion

Comment 5

[Frédéric Buclin]

Comment on attachment 173843 [details] [diff] [review]
Stephen's suggestion

Indeed much better than "this link". r=LpSolit

Comment 6

[Dave Miller [:justdave]]

works for me.

Comment 7

[Frédéric Buclin]

Checking in template/en/default/bug/create/make-template.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/make-template.html.tmpl,v
 <--  make-template.html.tmpl
new revision: 1.7; previous revision: 1.6
done