If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove UTF-8 BOMs from source files

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
UTF-8 BOMs (EF BB BF) at the beginning of source files are not good. Among other
problems they prevent LXR from indexing files. Example:
http://lxr.mozilla.org/seamonkey/find?string=bug41262 finds all files from
bug41262-1.html to bug41262-6.html, except for bug41262-2.html.
(Assignee)

Comment 1

13 years ago
Created attachment 173077 [details] [diff] [review]
Remove the BOMs
(Assignee)

Updated

13 years ago
Attachment #173077 - Flags: superreview?(brendan)
Attachment #173077 - Flags: review?(jshin1987)

Comment 2

13 years ago
Comment on attachment 173077 [details] [diff] [review]
Remove the BOMs

r=jshin
Perhaps, we have to document very clearly that UTF-8 BOM is not welcome in the
tree. (Windows users are prone to commit this mistake.)  In addition, an
automatic 'sanitizer' would be handy (how? hacking cvs server running at
cvs.mozilla.org or ...)
Attachment #173077 - Flags: review?(jshin1987) → review+
Comment on attachment 173077 [details] [diff] [review]
Remove the BOMs

rs=me on any such future changes.

/be
Attachment #173077 - Flags: superreview?(brendan) → superreview+
(Assignee)

Comment 4

13 years ago
Thanks for reviews, fix checked in.

(In reply to comment #2)
> Perhaps, we have to document very clearly that UTF-8 BOM is not welcome in the
> tree. (Windows users are prone to commit this mistake.)

We should certainly something like "don't save source files as UTF-8 from
Windows Notepad" to the docs at http://www.mozilla.org/hacking/

Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 5

13 years ago
For those who may come to this bug in the future: bug 280789 was filed for the
documentation. 
You need to log in before you can comment on or make changes to this bug.