280670 - After restarting Mozilla, user_pref("permissions.default.image") is always set to 1.

Status: RESOLVED FIXED

(Core :: Graphics: Image Blocking, defect)

Description

[hub-san]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050128
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050128

When "Accept images that come from the originating server only" is selected at
"Image Acceptance Policy" catagory, the setting is back in "Accept all images"
after restarting Mozilla.  The value of user_pref("permissions.default.image")
is always set to 1.  This value cannot be set to 2 or 3.

Reproducible: Always

Steps to Reproduce:
1. Delete or rename old profile directory.
2. Do first execution of Mozilla suite.
3. Goto Mozilla>Preferences...>Privacy & Security>Images 
4. Select "Accept images that come from the originating server only" in "Image
Acceptance Policy".
5. Restart Mozilla suite.
6. Goto Mozilla>Preferences...>Privacy & Security>Images

Actual Results:  
After restarting Mozilla, The setting of "Image Acceptance Policy" is back in
"Accept all images".  The value of user_pref("permissions.default.image") is
always set to 1.



Expected Results:  
After restarting Mozilla, The setting of "Image Acceptance Policy" is "Accept
images that come from the originating server only".  The value of
user_pref("permissions.default.image") can be set to 3(or 2).



I confirmed this problem on 2005-01-29-06-trunk of Mozilla suite
(MacOSX10.3.7).  2005-01-30-04-trunk had this problem, too.  But,
2005-01-28-05-trunk didn't have this bug.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

the migration code at
http://lxr.mozilla.org/seamonkey/source/extensions/permissions/nsContentBlocker.cpp#93
is broken.
I guess the rv of GetIntPref should actually be checked.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

like this

Comment 3

[[e-mail]]

Comment on attachment 173102 [details] [diff] [review]
patch v1

heh. r=me

Comment 4

[Darin Fisher]

Comment on attachment 173102 [details] [diff] [review]
patch v1

sr=darin

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 6

[OstGote!]

*** Bug 280924 has been marked as a duplicate of this bug. ***