Closed Bug 280778 Opened 15 years ago Closed 15 years ago

remove sendmail and qmail delivery methods on windows

Categories

(Bugzilla :: Email Notifications, defect)

2.19.2
x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file, 1 obsolete file)

Mail::Mailer doesn't support sendmail on windows for two reasons.  

firstly it looks for "/usr/lib/sendmail" (without the .exe) and will raise an
error if it doesn't exist.

if you tell Mail::Mailer to look for /usr/lib/sendmail.exe, it'll use a piped
open to spawn it, which isn't supported on windows.


for windows installs we should remove the sendmail delivery option, and default
instead to smtp.


ditto for qmail.
Attached patch remove sendmail, qmail v1 (obsolete) — Splinter Review
this patch removes sendmail and qmail from the list of options, and adds a
fixup to checksetup that switches the maildeliverymethod to smtp if on windows
and sendmail was selected.
Assignee: email-notifications → bugzilla
Status: NEW → ASSIGNED
Attachment #173176 - Flags: review?
the checksetup fixup is required as i was able to get bugzilla into a state
where i couldn't log in -- there was a pending password token request, which
trigged an email on login, which failed.
requesting blocking 2.20 -- when bugzilla tries to send email using the current
default configuration on windows (sendmail), the cgi goes into a spin and
eventually times out -- there's no error message.
Flags: blocking2.20?
Flags: blocking2.20?
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 173176 [details] [diff] [review]
remove sendmail, qmail  v1

Being that I don't have a Windows installation of Bugzilla I can't really test
this, but it doesn't interfere with the Linux version and all looks logical.
The one comment I have is:

>Index: checksetup.pl
>+    print "\nBugzilla requires a SMTP to function on Windows.\n" .

This sentence is not gramatically correct. It should either be "requires SMTP
to function" or "requires an SMTP server to function". Of the two, I think the
later is more techincally correct.

That is minor, however, and can be fixed on checkin.
Attachment #173176 - Flags: review? → review+
grammar and indentation fixes only.
carrying forward r=jake
Attachment #173176 - Attachment is obsolete: true
Attachment #176081 - Flags: review+
Flags: approval?
Comment on attachment 176081 [details] [diff] [review]
remove sendmail, qmail v2

It really should be "an SMTP server" or simply "SMTP".

Making it actually say "jake" by that r+
Flags: approval? → approval+
Fixed grammar on checkin, as per Jake's comment.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.361; previous revision: 1.360
done
Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.151; previous revision: 1.150
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.