280796 - Wrong JavaScript example for installing Firefox extension

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Met - Martin Hassman]

On the <http://www.mozilla.org/projects/firefox/extensions/web-api.html> is
JavaScript code for installing extension. But there is a mistake.

In the first color rectangle, there is:

"<a href="http://www.foo.com/bar.xpi" 
  iconURL="http://www.foo.com/bar.png"
  onclick="return install(this);">Install Extension!</a>"

But onclick="return install(this)" will not work, probably only typo. You have
to use onclick="return install(event);" as is in correct in the second color
rectangle.

Comment 1

[Anne (:annevk)]

Attachment: patch #1

This fixes that and some other nitpits.

Comment 2

[Anne (:annevk)]

Attachment: patch #2

Sorry about that.

Comment 3

[fantasai]

Comment on attachment 173182 [details] [diff] [review]
patch #2

Anne, I strongly suspect the language of this document is 'en' not 'nl'. Also,
since you are making a lot of whitespace-only changes, please attach a -w diff
for review.

Comment 4

[Anne (:annevk)]

Attachment: patch #3

Argh, I have seen too much HTML today I guess. -w coming up.

Comment 5

[Anne (:annevk)]

Attachment: patch #3 -w

Comment 6

[victory <[e-mail]>]

Attachment: script type text/javascript

script type should be text/javascript, isn't it?

Comment 7

[Anne (:annevk)]

FIXED