280807 - 004template.t miscalculates its number of checks

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Marc Schumann [:Wurblzap]]

Test 4 checks the references for each language, but it doesn't take more than
one language into account when calculating the total number of checks.

This is only visible when there's an additional language pack installed.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Vlad Dascalu]

Comment on attachment 173185 [details] [diff] [review]
Patch

Hi Marc,

Could you explain what each value means? @referenced_files, $num_actual_files
and why the latter is multiplied with 2?

Have you searched for similar errors in similar tests?

Thanks!

Comment 3

[Marc Schumann [:Wurblzap]]

(In reply to comment #2)

There are no other tests using @referenced_files.

The list @referenced_files contains all templates referenced by CGIs. Test 4
checks whether all these references can be fulfilled. Because it does this test
for all installed languages, the first part of the formula needs to be the
number of referenced files times the number of languages. The patch adds scaling
by number of languages.
The number of actual files, $num_actual_files, is the number of all template
files below the template/ directory. Two tests are performed on each -- a
compile test and a check for a version string. Therefore, the second part of the
formula is the number of files times two. The patch doesn't modify this second
part of the formula.

Comment 4

[Vlad Dascalu]

Comment on attachment 173185 [details] [diff] [review]
Patch

Thanks! Good to know!

I poked around the Support/Template.pm code but I couldn't find that with a
fast look. Maybe we need better code there or better comments.

Comment 5

[Dave Miller [:justdave]]

I believe we have this test on the 2.16 branch, too, and we did (sort of)
support language packs in 2.16, too.  If this is applicable, fix it there as
well, if not, retarget for 2.18 again.

Comment 6

[Marc Schumann [:Wurblzap]]

(In reply to comment #5)

The patch applies to 2.16.7, diff-wise as well as intent-wise. Neither
t/004template.t nor t/Support/Templates.pm differ in ways related to the patched
formula or the number of tests they do.

Comment 7

[Shane H. W. Travis]

2.16
Checking in t/004template.t;
/cvsroot/mozilla/webtools/bugzilla/t/004template.t,v  <--  004template.t
new revision: 1.15.2.4; previous revision: 1.15.2.3
done

2.18
Checking in t/004template.t;
/cvsroot/mozilla/webtools/bugzilla/t/004template.t,v  <--  004template.t
new revision: 1.32.2.1; previous revision: 1.32
done

tip
Checking in t/004template.t;
/cvsroot/mozilla/webtools/bugzilla/t/004template.t,v  <--  004template.t
new revision: 1.34; previous revision: 1.33
done