280889 - cursor can be used uninitialized in nsEventStateManager::UpdateCursor

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Veditz [:dveditz]]

If aTargetFrame is null then cursor can be used uninitialized in some cases in
nsEventStateManager::UpdateCursor.

Comment 1

[Daniel Veditz [:dveditz]]

Attachment: initialize cursor

Caught using /RTCu windows compiler option, uninitialized use seen in action.
If aTargetFrame is null we don't try to set the real cursor to this value, but
it is used in a couple comparisons still.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 173236 [details] [diff] [review]
initialize cursor

Shouldn't that be !CheckDisabled ?

Comment 3

[Daniel Veditz [:dveditz]]

Attachment: correct version

Of course it should be (I blame the codeine). Thanks!

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 173245 [details] [diff] [review]
correct version

r+sr=bzbarsky

Comment 5

[Daniel Veditz [:dveditz]]

Also found by Coverity

Comment 6

[Daniel Veditz [:dveditz]]

Checked into trunk