280921 - Kill nsCheapStringBufferUtils

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

With darins recent changes that allows us to use the nsStringBuffer class, most
functions in nsCheapStringBufferUtils are just one or twoliners calling methods
in that class. In fact, after expanding such methods into nsAttrValue the only
function remaining is CopyToBuffer which is called at exactly one place. So it
felt a bit silly to keep even that one around.

The only functional impact of this change should be one refcount less when
cloning an nsAttrValue containing a string.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Alternativly we could create a more generic helperclass (one with a better
syntax too) that lives in xpcom/string

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in. Thanks for review