280971 - calIDateTime properties like hour should all be in the given timezone

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

calIDateTime.hour should give (and set) the hour in the timezone the object is in.
Also, converting from utc should really work. libical is broken, and doesn't set
is_utc.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: v1

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hmm, I'm wondering what the potential breakage of doing this is.  The comments
in calIDateTime.idl need to be updated as well, because by doing this we're
elevating the .timezone field to more than just the preferred serialization
timezone.  Do datetime comparisons, etc. still work?  Same with assignment
to/from jsDates?

I guess a test suite would help answer these questions =/

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

if .timezone only means what the prefered serialization is, you can't do
timezone calculations at all. And they are needed. (if only to convert from the
stored timezone to the timezone used to display)
I have to test comparision. I do have some tests for timezone calculation and
for jsDate. I will clean them up and publish them.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: testcase

This testcase tests timezone conversion and compare in different timezones.
With the patch, the testcase succeeds. without the patch, it fails.
(but ofcourse the testcase is based on the new meaning of the properties)

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 173308 [details] [diff] [review]
v1

r=vladimir, good enough for me.  let's land it and fix whatever breaks.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in