281011 - mk-MK l10n bookmarks review

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, enhancement)

Description

[Damjan Georgievski]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

As requested by Zbigniew Braniecki in bug #276345, I'm submiting the
bookmarks.html file, of the macedonian localization of Firefox-1.0, for review
by Rafael Ebron.

Reproducible: Didn't try

Comment 1

[Damjan Georgievski]

Attachment: bookmarks.html

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Damjan: please, describe every entry, you used in your bookmarks that is not
from english ones.

Comment 3

[Damjan Georgievski]

I'd like to explain how we made that bookmarks file for the macedonian 
firefox. I've mainly looked upon the slovenian bookmarks file, and the 
modifications to the original bookmarks are very similar to how they've 
modified it.

1. The "QuickSearches" and "Firefox and Mozilla links" folders are only 
translated.
2. There's one addition in the QuickSearches, that's for a macedonian search 
engine written using opensource tools (http://najdi.org.mk/).
3. The "Bookmarks Toolbar Folder" has the "Gettig started" link (translated) 
that points to 
http://www.mozilla-europe.org/mk/products/firefox/start/central.html.

And the BBC RSS feed is changed to 2 feeds of two interesting macedoian sites 
(one a linux portal, the other is a very much broad community site).

4. We've also added a new folder with macedonian sites. The sites are:
- the site of the organization free software macedonia (that's us)
- link to a planet that collects the blogs of FSM members
- the linux portal
and then we added links to the websites of different media houses, newspapers, 
TV stations, radio stations, similar organizations etc. 
We hope that we can use the fact that we "advertise" them in the bookmarks, so 
that they help us in promoting the macedonian firefox (when its released).

Comment 4

[Axel Hecht]

(In reply to comment #3)
<...>
> 3. The "Bookmarks Toolbar Folder" has the "Gettig started" link (translated) 
> that points to 
> http://www.mozilla-europe.org/mk/products/firefox/start/central.html.

The first link in the mozilla category should be linking there, too.

> And the BBC RSS feed is changed to 2 feeds of two interesting macedoian sites 
> (one a linux portal, the other is a very much broad community site).
> 
> 4. We've also added a new folder with macedonian sites. The sites are:

Sorry, crew picks died. I'm not rebron, but this should still be the case.

If you have a new one, please request approval-l10n, like for other patches 
on the managed branch as well.

Comment 5

[Damjan Georgievski]

>> 3. The "Bookmarks Toolbar Folder" has the "Gettig started" link (translated) 
>> that points to 
>> http://www.mozilla-europe.org/mk/products/firefox/start/central.html.
> 
> The first link in the mozilla category should be linking there, too.

I'll correct that.

> > And the BBC RSS feed is changed to 2 feeds of two interesting macedoian sites 
> > (one a linux portal, the other is a very much broad community site).
> > 
> > 4. We've also added a new folder with macedonian sites. The sites are:
> 
> Sorry, crew picks died. I'm not rebron, but this should still be the case.
> 
> If you have a new one, please request approval-l10n, like for other patches 
> on the managed branch as well.

I don't understand what are you saying here? 

Comment 6

[Damjan Georgievski]

Attachment: bookmarks.html

Here's the new bookmarks file.
Only one local quick search is added, and urbandictionary.com s removed.

The other bookmarks are translated, and links goinf to english sites (most of
them) are clearly marked with an "[en]".

Is it ok now?

Comment 7

[Axel Hecht]

Comment on attachment 174550 [details]
bookmarks.html

Please request approval-l10n for stuff that you want to land, otherwise it will
slip.
This one looks cool to me.

Comment 8

[Damjan Georgievski]

Attachment: bookmarks.html

I've changed the default RSS to the RSS of an official macedonian news agency
(they created the RSS feed just now).

Also added a bookmark to a local forum about firefox and thunderbird.

Please review.

Comment 9

[Axel Hecht]

Comment on attachment 175302 [details]
bookmarks.html

that feed link is wrong, it partly still links to mozillazine.

Please submit a patch, too, cvs -z3 diff -u.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

checking in mk-MK with second bookmarks.html.

Comment 11

[Damjan Georgievski]

Attachment: patch to approved (second) bookmarks.html attachment

> that feed link is wrong, it partly still links to mozillazine.

Ahh, I hate this kind of overlooks. Patch submitted. 
Sorry for annoying you.

Comment 12

[Axel Hecht]

Comment on attachment 175336 [details] [diff] [review]
patch to approved (second) bookmarks.html attachment

yep, this is much better.

Comment 13

[Damjan Georgievski]

The patch commited to CVS