Closed Bug 281037 Opened 20 years ago Closed 9 years ago

nsSocketTransportService should create mEventQLock in the Init method associated with its genericfactory

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: timeless, Unassigned)

References

(
URL
)

Details

(Keywords: helpwanted, Whiteboard: [necko-backlog])

PR_NewLock can fail, if it does, we'll crash. Note that it's not particularly good form to have a method Init() which is both exposed via idl: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/public/nsISocketTransportService.idl&rev=1.28&mark=76#73 and used by xpcom as part of construction: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/build/nsNetModule.cpp&rev=1.119&mark=88#84
I absolutely want to remove the init methods from necko idls (there are still two of them, iirc - sts and dnsservice), but ioservice needs them so it's not trivial.
agreed. i welcome a patch to fix these issues.
Assignee: darin → nobody
QA Contact: benc → networking
Keywords: crash
Whiteboard: [necko-backlog]
This code is not there any more and init is not expose through a public idl any more. I will close this bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.