281101 - Return CHILDID_SELF for get_accFocus on currently focused accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Our current behavior breaks some Window-Eyes commands that deal with text editing.

Currently we always return VT_EMPTY on non-document accessibles for the focused
child.

We should return CHILDID_SELF if the current accessible has focus.

Comment 1

[Aaron Leventhal]

Attachment: Simple patch

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Your comment doesn't match the code:

+  // We return CHILD_ID_SELF if we currently have focus

Shouldn't that be CHILDID_SELF?

Comment 3

[Philip K. Warren]

Comment on attachment 173398 [details] [diff] [review]
Simple patch

r=pkw after fixing the comment issue addressed by the comment above.

Comment 4

[Aaron Leventhal]

Checking in nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v  <-- 
nsDocAccessibleWrap.cpp
new revision: 1.21; previous revision: 1.20
done

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381